Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secret DataStore Crypto Key should not be created when existing provided #386

Closed
bmarick opened this issue Jan 19, 2024 · 0 comments
Closed

Secret DataStore Crypto Key should not be created when existing provided #386

bmarick opened this issue Jan 19, 2024 · 0 comments

Comments

@bmarick
Copy link
Contributor

bmarick commented Jan 19, 2024 •
edited
Loading

During testing of the main branch I found that the secrets_datastore_crypto_key.yaml is still created when when st2.existingDatastoreSecret is set.
Based on the values.yml that is not the expected behavior.

st2:
  # ... reducing for clarity  ...
  # Name of existing ST2 datastore secret, disables creation of this secret
  # existingDatastoreSecret: ""
  # ... reducing for clarity  ...

I will submit a PR to fix that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bmarick