Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secret DataStore Crypto Key should not be created when existing provided #385

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Secret DataStore Crypto Key should not be created when existing provided #385

merged 2 commits into from
Jan 23, 2024

Conversation

bmarick
Copy link
Contributor

@bmarick bmarick commented Jan 19, 2024 •
edited

Changes:

  • Update secrets_datastore_crypto_key.yaml to prevent creation when st2.existingDatastoreSecret is set
  • Add unit tests to validate changes
  • Fix unit test syntax

Addresses Issue #386

@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines. Requires some effort to review. label Jan 19, 2024
guzzijones
guzzijones approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@guzzijones guzzijones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@guzzijones guzzijones merged commit 44aa43a into StackStorm:master Jan 23, 2024
8 checks passed
@bmarick bmarick deleted the disableGenerateDatastoreCryptoKey branch January 24, 2024 10:01
@cognifloyd cognifloyd added enhancement New feature or request Helm labels Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guzzijones guzzijones guzzijones approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Helm size/L PR that changes 100-499 lines. Requires some effort to review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bmarick @guzzijones @cognifloyd