Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mounting of NFS volumes instead of using st2packs for pack management #118

Closed

Conversation

valentintorikian
Copy link
Contributor

@valentintorikian valentintorikian commented Mar 9, 2020

This should close #18

This will allow the end users to mount NFS volumes to manage their custom packs. To be noted: when using an NFS mount, the lifecycle management of the packs (installing/updating/registering) is deferred back to the stackstorm administrators.
One way to do it would be to trigger packs installation and/or registration through the API using
https://api.stackstorm.com/api/v1/packs/#/packs_controller.install.post
https://api.stackstorm.com/api/v1/packs/#/packs_controller.register.post
or directly through the st2client pod.

The st2packs method is of course still available. If both st2.packs.image.repository and st2.packs.nfs.server are set, the st2packs image will be used.

@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines. Good size to review. label Mar 9, 2020
@valentintorikian valentintorikian changed the title Allow mounting of NFS volumes instead of using st2packs for pack mangement Allow mounting of NFS volumes instead of using st2packs for pack management Mar 9, 2020
@arm4b arm4b self-assigned this Mar 9, 2020
@arm4b
Copy link
Member

arm4b commented Mar 11, 2020

@hnanchahal I think you might be interested in this story of sharing pack content via NFS mount as you did something similar.
Can you also take a look at PR and provide feedback?

@arm4b arm4b added the feature label Mar 11, 2020
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! 👍

We'll need more details/instructions for users to make this NFS story more clear and easy.
Also can you provide an example about how to install/configure NFS in K8s and respective Helm values? So someone reviewing this will follow that to verify this feature/story.

CHANGELOG.md Outdated Show resolved Hide resolved
values.yaml Show resolved Hide resolved
@valentintorikian
Copy link
Contributor Author

Also can you provide an example about how to install/configure NFS in K8s and respective Helm values? So someone reviewing this will follow that to verify this feature/story.

Isn't that a bit out of scope ?

@arm4b
Copy link
Member

arm4b commented Mar 11, 2020

Having the full example is out of scope for the README, but it'll be good to have this kind of info in this issue to help someone test and try it end to end.

@arm4b
Copy link
Member

arm4b commented Mar 11, 2020

Overall with NFS like distributing pack content we provide a story/solution for the user.
For instance, custom st2packs has
https://docs.stackstorm.com/install/k8s_ha.html#custom-st2-packs
https://github.com/stackstorm/stackstorm-ha#install-custom-st2-packs-in-the-cluster
https://github.com/StackStorm/st2packs-dockerfiles/
as a helpers to guide users about preparing custom packs in K8s environment.
Alternative solution with NFS shouldn't have less information about how to use it and overall what steps to follow.

templates/jobs.yaml Outdated Show resolved Hide resolved
Co-Authored-By: Eugen C. <armab@users.noreply.github.com>
@arm4b arm4b added the help wanted Extra attention is needed label Apr 27, 2020
@pull-request-size pull-request-size bot added size/L PR that changes 100-499 lines. Requires some effort to review. and removed size/M PR that changes 30-99 lines. Good size to review. labels Sep 22, 2020
@arm4b arm4b added the status:on hold Feature, design or idea with undecided status to include in the project functionality label Dec 14, 2020
@chris3081
Copy link

chris3081 commented Jan 18, 2021

I would love to see a deployment engine in front of this like a Jenkins lite (API / UI) which has write on the volume.. It would offer a clean deployment solution and might allow us to have something in the runners, st2api, st2client etc to install pack OS dependencies, tho I'm not 100% sure how it would work at the moment, but maybe the actionrunner could be commanded by the deployment engine to install OS packs (would need to account for the st2api which runs as stanley)

@ericreeves
Copy link
Contributor

Greetings! This PR needs a rebase given the big upstream changes from master, which I have been unsuccessful at so far. Anybody else have any luck? :)

cognifloyd added a commit to cognifloyd/stackstorm-k8s that referenced this pull request Jun 17, 2021
@cognifloyd
Copy link
Member

Thanks for this PR! I used some of the ideas here in building #199 . I need flexVolume + ceph-rook, you need NFS, and others will need who knows which storage solution, so I tried to make something that was both generic and simple. What do you think of #199? Will that work for you?

cognifloyd added a commit to cognifloyd/stackstorm-k8s that referenced this pull request Jun 19, 2021
cognifloyd added a commit to cognifloyd/stackstorm-k8s that referenced this pull request Jul 1, 2021
cognifloyd added a commit to cognifloyd/stackstorm-k8s that referenced this pull request Jul 3, 2021
cognifloyd added a commit to cognifloyd/stackstorm-k8s that referenced this pull request Jul 3, 2021
cognifloyd added a commit to cognifloyd/stackstorm-k8s that referenced this pull request Jul 3, 2021
cognifloyd added a commit to cognifloyd/stackstorm-k8s that referenced this pull request Jul 6, 2021
cognifloyd added a commit to cognifloyd/stackstorm-k8s that referenced this pull request Jul 6, 2021
ericreeves pushed a commit to alertlogic/stackstorm-ha that referenced this pull request Jul 9, 2021
cognifloyd added a commit to cognifloyd/stackstorm-k8s that referenced this pull request Jul 10, 2021
cognifloyd added a commit to cognifloyd/stackstorm-k8s that referenced this pull request Jul 10, 2021
cognifloyd added a commit to cognifloyd/stackstorm-k8s that referenced this pull request Jul 13, 2021
cognifloyd added a commit to cognifloyd/stackstorm-k8s that referenced this pull request Jul 17, 2021
@cognifloyd
Copy link
Member

@angrydeveloper could you review #199? Is there anything missing from #199 that you included in this PR, or that you think would be better a different way?

@cognifloyd
Copy link
Member

If #199 is satisfactory for you, then I think we could close this PR. What do you think?

@arm4b arm4b closed this in #199 Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature help wanted Extra attention is needed size/L PR that changes 100-499 lines. Requires some effort to review. status:feedback needed status:on hold Feature, design or idea with undecided status to include in the project functionality status:under discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sharing pack content: Bundle custom st2packs image vs Shared NFS storage?
5 participants