Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide option for alternate docker repository #131

Merged
merged 4 commits into from
May 12, 2020

Conversation

ytjohn
Copy link
Contributor

@ytjohn ytjohn commented May 11, 2020

We need the option to pull images from an internal docker repository. This PR allows us to specify the name of the repository, while still allowing default and enterprise.

@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines. Very easy to review. label May 11, 2020
@arm4b arm4b self-requested a review May 12, 2020 13:20
@arm4b arm4b self-assigned this May 12, 2020
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me,

I left a couple of comments to address.
Please also include the CHANGELOG record.

values.yaml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/XS PR that changes 0-9 lines. Quick fix/merge. and removed size/S PR that changes 10-29 lines. Very easy to review. labels May 12, 2020
@pull-request-size pull-request-size bot added size/S PR that changes 10-29 lines. Very easy to review. and removed size/XS PR that changes 0-9 lines. Quick fix/merge. labels May 12, 2020
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Thanks 👍

@arm4b arm4b merged commit 0070550 into StackStorm:master May 12, 2020
@arm4b
Copy link
Member

arm4b commented May 18, 2020

This change was released as v0.28.0 chart version:
https://github.com/StackStorm/stackstorm-ha/releases/tag/v0.28.0

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S PR that changes 10-29 lines. Very easy to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants