-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option to define config.js for st2web #165
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! That's a nice composed feature 👍
I just left one comment before we can merge it.
Please also sync up your PR branch with the latest |
1c51038
to
5b0e759
Compare
Rebased :) |
Thanks @moonrail! |
5b0e759
to
9846c59
Compare
@armab |
You're definitely faster then I am with the other PRs :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice feature, thanks a lot for implementation! 👍
Hello maintainers,
while testing and developing internally we've experienced the requirement, where we would have to access StackStorm in a subpath of a FQDN, e.g.
sub.domain.tld/stackstorm
.For this configuration is required for Ingress and
st2web
.This PR adds the possibility to define configuration for
st2web
.Ingress is pretty straight forward and already supported, e.g.:
With this Ingress configuration,
st2web
is properly reachable.By default
st2web
uses relative paths to its domain to access services likeauth
,api
, andstream
. So for our example,st2web
would try to authenticate againstsub.domain.tld/auth
.A solution is described here: https://github.com/StackStorm/st2web#connecting-to-st2-server
In short: Edit /opt/stackstorm/static/webui/config.js to include complete Endpoints for
auth
,api
, andstream
.For our example config.js could be: