remove lingering reference to enterprise st2-license pullSecret #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
arm4b
suggested changes
Jun 15, 2021
There was a problem hiding this comment.
Good find! 👍
@cognifloyd For better visibility, this still needs a Changelog record for history, to associate with the respective PRs #, and also because these two changes are part of the different releases.
Hope that makes sense.
cognifloyd
force-pushed
the
enterprise-cleanup
branch
from
2fc122c
to
40c06a3
Compare
|
I added a changelog entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was one more reference to
{{ .Release.name }}-st2-licensewhich was removed everywhere else in #182.This removes the straggler.
As a follow-up to the already merged #182, this should not need a changelog entry. edit: added changelog entry