Allow adding nodeSelector, affinity, tolerations to batch Jobs #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
cognifloyd
force-pushed
the
advanced-pod-placement
branch
3 times, most recently
from
272f072
to
8356a5f
Compare
cognifloyd
changed the title
This comment has been minimized.
This comment has been minimized.
cognifloyd
added
feature
RFR
enhancement
cognifloyd
force-pushed
the
advanced-pod-placement
branch
from
8356a5f
to
1719b13
Compare
This comment has been minimized.
This comment has been minimized.
cognifloyd
force-pushed
the
advanced-pod-placement
branch
2 times, most recently
from
a95068d
to
9ea013c
Compare
|
rebased on master |
cognifloyd
force-pushed
the
advanced-pod-placement
branch
2 times, most recently
from
c779c95
to
35b72e7
Compare
This comment has been minimized.
This comment has been minimized.
cognifloyd
force-pushed
the
advanced-pod-placement
branch
from
f215db2
to
07fd706
Compare
This comment has been minimized.
This comment has been minimized.
cognifloyd
force-pushed
the
advanced-pod-placement
branch
from
07fd706
to
15ba022
Compare
cognifloyd
force-pushed
the
advanced-pod-placement
branch
from
15ba022
to
b1a4b25
Compare
pull-request-size
bot
added
size/M
|
@armab I got this PR down to |
cognifloyd
force-pushed
the
advanced-pod-placement
branch
from
b1a4b25
to
b0a409a
Compare
cognifloyd
changed the title
arm4b
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our cluster has dedicated nodes for StackStorm. So I need a way to specify the advanced placement settings (nodeSelector, affinity, tolerations) on the batch jobs as well.
add advanced-pod-placement helper. This reduces duplication in the deployments file.edit: moved to yaml template style: use nindent for nodeSelector, affinity, tolerations #216