Add optional (advanced-only) hubot-scripts volume to st2chatops pod #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/S
cognifloyd
force-pushed
the
chatops-scripts
branch
from
03c37fd
to
ab51163
Compare
cognifloyd
force-pushed
the
chatops-scripts
branch
from
ab51163
to
8492afa
Compare
|
rebased on master |
arm4b
reviewed
Jun 26, 2021
This is for advanced use-cases only, and should generally not be used. However, adding volumes is not possible from parent helm charts, so this is a limited, but useful, extension point.
cognifloyd
force-pushed
the
chatops-scripts
branch
from
8492afa
to
f867681
Compare
pull-request-size
bot
added
size/M
cognifloyd
changed the title
cognifloyd
force-pushed
the
chatops-scripts
branch
from
f867681
to
2824650
Compare
pull-request-size
bot
added
size/S
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for advanced use-cases only, and should generally not be used.
However, adding volumes is not possible from parent helm charts, so this is a limited, but useful, extension point.
I need to support an in-house acl solution for hubot. We use a hubot script to provide that feature. Given the current chart, there is no clean way to inject these scripts before chatops is started. This PR adds a simple, targeted way to enable this feature while keeping its footprint small.
NB. In my case, I have a custom docker image that includes the dependencies for my script, but there is also a config file that needs to be deployed via a volume of some kind, so embedding that in the docker image as well isn't feasible.