Add helm-unittest #284
Add helm-unittest #284
Conversation
pull-request-size
bot
added
the
size/L
There was a problem hiding this comment.
Thanks for composing a quick example, looks really sleek! 👍
Do we want to split the directory structure here, considering we now have unit vs integration tests?
https://github.com/StackStorm/stackstorm-ha/tree/master/tests
Adding a new Readme.md for Unit tests would be helpful as well.
I'd welcome the changelog as that'll help other developers seeing unit test framework addition as another stability message.
| @@ -18,4 +47,4 @@ To show the test results: | |||
| kubectl logs <release-name>-st2tests | |||
| ``` | |||
|
|
|||
| See https://helm.sh/docs/developing_charts/#chart-tests with more information about Helm chart tests. | |||
| See https://helm.sh/docs/topics/chart-tests/ with more information about Helm chart tests. | |||
There was a problem hiding this comment.
old link was to helm v2 docs. This is the same doc but for helm v3.
|
I added tests for custom annotations and removed the dummy unit test. |
| - it: Deployments+Pods accept custom annotations | ||
| template: deployments.yaml | ||
| set: |
There was a problem hiding this comment.
Testing all the deployment annotations at once is an optimization. I had one test per deployment, but that meant one helm template run per deployment, which made things very very slow (no I didn't time the multi-minute slow runs, but I got the test run down to about a minute on my machine).
There was a problem hiding this comment.
No problem with running helm unittest --helm3 -f tests/unit/*_test.yaml to structure the tests in unit/ and integration/ dirs.
Looks like the others were successful in this already:
https://github.com/jenkinsci/helm-charts/blob/26affd02465f7ef444967b0528142a6cd6b9642a/ct.yaml#L8
Let's please do something similar.
I understand it comes with a price of adding another -f tests/unit/*_test.yaml CLI param, but the other side is that the structure would be more obvious and predictable for everyone.
Co-authored-by: Eugen Cusmaunsa <stackstorm@armab.io>
Drop the warnings/complaints about how awkward it is to use helm-unittest. Co-authored-by: Eugen Cusmaunsa <stackstorm@armab.io>
Co-authored-by: Eugen Cusmaunsa <stackstorm@armab.io>
Per #28 and #283 (review) unittests will use helm-unittest.
This adds a basic GHA workflow and a single dummy test. The dummy test is commented to document the various options in the test file.