Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Cover the three most recent Kubernetes versions in Minikube and the single most recent in K3s #346

Merged
merged 7 commits into from
Jan 6, 2023
Merged

CI: Cover the three most recent Kubernetes versions in Minikube and the single most recent in K3s #346

merged 7 commits into from
Jan 6, 2023

Conversation

mamercad
Copy link
Contributor

@mamercad mamercad commented Dec 23, 2022 •
edited
Loading

Relates to #342.

@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines. Very easy to review. label Dec 23, 2022
@mamercad mamercad changed the title CI: Add three current Kubernetes versions CI: Cover three current Kubernetes versions (Experimental K3s E2E) Dec 23, 2022
@mamercad mamercad marked this pull request as ready for review December 23, 2022 14:38
arm4b
arm4b reviewed Dec 29, 2022
View reviewed changes
.github/workflows/e2e.yaml Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/M PR that changes 30-99 lines. Good size to review. size/S PR that changes 10-29 lines. Very easy to review. and removed size/S PR that changes 10-29 lines. Very easy to review. size/M PR that changes 30-99 lines. Good size to review. labels Jan 5, 2023
@mamercad mamercad changed the title CI: Cover three current Kubernetes versions (Experimental K3s E2E) CI: Cover more current Kubernetes versions Jan 6, 2023
@mamercad mamercad requested a review from arm4b January 6, 2023 02:43
arm4b
arm4b suggested changes Jan 6, 2023
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on that and all the debugging!

Left one change comment to assist, so we can really test with the 3 K8s versions and just the latest minikube (can even unpin it, if you'd like).

.circleci/config.yml Outdated Show resolved Hide resolved
@arm4b arm4b added enhancement New feature or request CI/CD labels Jan 6, 2023
@pull-request-size pull-request-size bot added size/M PR that changes 30-99 lines. Good size to review. and removed size/S PR that changes 10-29 lines. Very easy to review. labels Jan 6, 2023
@mamercad mamercad changed the title CI: Cover more current Kubernetes versions CI: Cover three current Kubernetes versions Jan 6, 2023
@mamercad mamercad changed the title CI: Cover three current Kubernetes versions CI: Cover three most recent Minikube versions and the most recent K3s version Jan 6, 2023
@mamercad mamercad changed the title CI: Cover three most recent Minikube versions and the most recent K3s version CI: Cover the three most recent Kubernetes versions in Minikube and the single most recent in K3s Jan 6, 2023
arm4b
arm4b approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Just one comment about the K8s version.

.circleci/config.yml Outdated Show resolved Hide resolved
@arm4b arm4b enabled auto-merge January 6, 2023 19:37
@arm4b arm4b merged commit aced661 into StackStorm:master Jan 6, 2023
@mamercad mamercad deleted the k3s-channel-coverage branch January 6, 2023 20:11
@mamercad mamercad mentioned this pull request Jan 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arm4b arm4b arm4b approved these changes

Assignees
No one assigned
Labels
CI/CD enhancement New feature or request size/M PR that changes 30-99 lines. Good size to review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mamercad @arm4b