Turn off unnecessary processing and add doc links. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkschulz
reviewed
Mar 15, 2019
agents.yaml
Outdated
| @@ -437,10 +437,11 @@ metadata: | |||
| labels: | |||
| app: stackdriver-log-forwarder | |||
| data: | |||
| # Configuration files: server, input, filters and output | |||
| # Configuration files for service, input, filters and output plugins. | |||
There was a problem hiding this comment.
filters and → filter, and
jkschulz
reviewed
Mar 15, 2019
log-forwarder.yaml
Outdated
| Name kubernetes | ||
| Match k8s_container.* | ||
| Kube_URL https://kubernetes.default.svc.cluster.local:443 | ||
| Merge_Log Off | ||
| K8S-Logging.Parser On | ||
| K8S-Logging.Parser Off |
There was a problem hiding this comment.
This and Merge_Log are already Off by default so you can remove those lines (unless you want it explicit)
There was a problem hiding this comment.
Ah, right. Removed.
qingling128
commented
Mar 15, 2019
agents.yaml
Outdated
| @@ -437,10 +437,11 @@ metadata: | |||
| labels: | |||
| app: stackdriver-log-forwarder | |||
| data: | |||
| # Configuration files: server, input, filters and output | |||
| # Configuration files for service, input, filters and output plugins. | |||
log-forwarder.yaml
Outdated
| Name kubernetes | ||
| Match k8s_container.* | ||
| Kube_URL https://kubernetes.default.svc.cluster.local:443 | ||
| Merge_Log Off | ||
| K8S-Logging.Parser On | ||
| K8S-Logging.Parser Off |
There was a problem hiding this comment.
Ah, right. Removed.
jkschulz
approved these changes
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.