Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid loading resources from the network on make format #192

Merged
merged 6 commits into from Oct 29, 2019
Merged

Avoid loading resources from the network on make format #192

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c62db9d
Invoke go fmt with `mod=vendor`
jkohen Oct 28, 2019
4f2fd12
Update Makefile
jkohen Oct 28, 2019
379e7fc
Update Makefile
jkohen Oct 28, 2019
e3d6531
Update Makefile
jkohen Oct 28, 2019
aea4f78
Update Makefile
jkohen Oct 28, 2019
82896c2
Update Makefile
jkohen Oct 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion Makefile
View file
Open in desktop
Expand Up @@ -79,7 +79,10 @@ cover:

format:
@echo ">> formatting code"
GO111MODULE=$(GO111MODULE) $(GO) fmt $(pkgs)
# Replace gofmt call once we bump to a more recent Go that supports `-mod=vendor`, probably 1.14.
# GO111MODULE=$(GO111MODULE) $(GO) fmt $(GOOPTS) $(pkgs)
# Avoid formatting anything under vendor/.
$(GOFMT) -l -w $(shell find . -path ./vendor -prune -o -name '*.go' -print)
jkohen marked this conversation as resolved.
Show resolved Hide resolved

vet:
@echo ">> vetting code"
Expand Down