Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle empty strings in custom comments #36

Merged
merged 7 commits into from
May 23, 2022
Merged

handle empty strings in custom comments #36

merged 7 commits into from
May 23, 2022

Conversation

staffbase-robert
Copy link
Contributor

@staffbase-robert staffbase-robert commented Apr 7, 2022 •
edited by flaxel
Loading

Type of Change

  • Bugfix
  • Enhancement / new feature
  • Refactoring
  • Documentation

Description

  • the action would create an empty comment, if the CI definition includes no custom comment string
  • the action should now fallback to the default comment
  • you can test it with this repo

Checklist

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Review the Contributing Guideline and sign CLA
  • Reference relevant issue(s) and close them after merging

@staffbase-robert staffbase-robert force-pushed the fix/custom-comment-fallback branch 2 times, most recently from b4d61ac to b44e5ef Compare April 7, 2022 12:15
@flaxel flaxel added the bug Something isn't working label May 18, 2022
@flaxel flaxel force-pushed the fix/custom-comment-fallback branch from fe9a8d1 to b373c39 Compare May 18, 2022 08:57
@staffbase-robert staffbase-robert merged commit a807ee9 into master May 23, 2022
@staffbase-robert staffbase-robert deleted the fix/custom-comment-fallback branch May 23, 2022 08:55
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@flaxel flaxel flaxel approved these changes

@0x46616c6b 0x46616c6b Awaiting requested review from 0x46616c6b

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@staffbase-robert @flaxel