Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace tibdex app token action by one from GitHub #225

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Replace tibdex app token action by one from GitHub #225

merged 1 commit into from
Feb 14, 2024

Conversation

timdittler
Copy link
Contributor

Type of Change

  • Bugfix
  • Enhancement / new feature
  • Refactoring
  • Documentation

Description

Replace tibdex app token action by one from GitHub.
We prefer actions from GH to ones from private people.

Checklist

  • Add relevant labels (for example type of change or patch/minor/major)
  • Make sure not to introduce some mistakes
  • Update documentation
  • Review the Contributing Guideline and sign CLA
  • Reference relevant issue(s) and close them after merging

@timdittler timdittler added enhancement New feature or request dependencies Pull requests that update an action file patch Pull request with little updates labels Feb 13, 2024
@timdittler timdittler marked this pull request as ready for review February 13, 2024 14:23
@timdittler timdittler requested a review from a team as a code owner February 13, 2024 14:23
flaxel
flaxel reviewed Feb 13, 2024
View reviewed changes
Copy link
Contributor

@flaxel flaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh really nice. 🎉 Only one notice because I'm not sure: There is no behavior change and a user shouldn't see any difference? 🤔

@timdittler
Copy link
Contributor Author

Uh really nice. 🎉 Only one notice because I'm not sure: There is no behavior change and a user shouldn't see any difference? 🤔

Yes, there should be absolutely no change in behavior.

@timdittler timdittler merged commit b01d4f6 into main Feb 14, 2024
2 checks passed
@timdittler timdittler deleted the github-token-action branch February 14, 2024 06:50
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@flaxel flaxel flaxel left review comments

@0x46616c6b 0x46616c6b 0x46616c6b approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update an action file enhancement New feature or request patch Pull request with little updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timdittler @0x46616c6b @flaxel