Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Use node20 #116

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Fix: Use node20 #116

merged 1 commit into from
Mar 12, 2024

Conversation

soemo
Copy link
Contributor

@soemo soemo commented Mar 12, 2024 •
edited
Loading

use node20

In this PR https://github.com/Staffbase/github-action-jira-release-tagging/pull/114/files I changed the used node version for the action to node21. This was wrong as stated in the frontend workflow now

https://github.com/Staffbase/frontend/actions/runs/8249283571/job/22561334164

Error: System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. 
(Parameter ''using: node21' is not supported, use 'docker', 'node12', 'node16' or 'node20' instead.')
   at GitHub.Runner.Worker.ActionManifestManager.ConvertRuns(IExecutionContext executionContext, TemplateContext templateContext, TemplateToken inputsToken, String fileRelativePath, MappingToken outputs)
   at GitHub.Runner.Worker.ActionManifestManager.Load(IExecutionContext executionContext, String manifestFile)
Error: Failed to load Staffbase/github-action-jira-release-tagging/v1.3.0/action.yml

TODOs

  • create new version and add it to the gha-workflow + create new github action workflow

Type of Change

  • Bugfix
  • Enhancement / new feature
  • Refactoring
  • Documentation

Description

Checklist

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Review the Contributing Guideline and sign CLA
  • Reference relevant issue(s) and close them after merging

@soemo
Use node20
06e197b 
use node20

In this PR https://github.com/Staffbase/github-action-jira-release-tagging/pull/114/files i changed the used node version for the action to node21. This was wrong ans stated in the frontend workflow now

https://github.com/Staffbase/frontend/actions/runs/8249283571/job/22561334164
@soemo soemo requested a review from a team as a code owner March 12, 2024 13:16
@soemo soemo requested review from flaxel, a team, SixDollarMan and ikortelainen and removed request for a team March 12, 2024 13:16
@soemo soemo merged commit ff742d3 into master Mar 12, 2024
1 check passed
@soemo soemo deleted the fix-use-node20 branch March 12, 2024 13:36
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
soemo added a commit to Staffbase/gha-workflows that referenced this pull request Mar 12, 2024
@soemo
Update github-action-jira-release-tagging
b3d7e09 
Update github-action-jira-release-tagging to version 1.3.1
includes the workflow fix Staffbase/github-action-jira-release-tagging#116
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timdittler timdittler timdittler approved these changes

@flaxel flaxel Awaiting requested review from flaxel

@SixDollarMan SixDollarMan Awaiting requested review from SixDollarMan

@ikortelainen ikortelainen Awaiting requested review from ikortelainen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@soemo @timdittler