Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Readme and enhance pipeline #7

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Update Readme and enhance pipeline #7

merged 1 commit into from
Jul 7, 2021

Conversation

axdotl
Copy link
Member

@axdotl axdotl commented Jul 6, 2021 •
edited
Loading

  • Updated README
  • Make use of goreleaser
  • Adjust ci-cd pipeline and publish to DockerHub

@axdotl axdotl requested a review from a team as a code owner July 6, 2021 12:54
@axdotl axdotl requested review from 0x46616c6b, ricoberger and kaitimmer and removed request for a team July 6, 2021 12:54
@axdotl axdotl changed the title Update Readme Update Readme and add release drafter Jul 6, 2021
@axdotl axdotl requested review from monotek and kaitimmer July 7, 2021 06:55
@axdotl axdotl changed the title Update Readme and add release drafter Update Readme and enhance pipeline Jul 7, 2021
0x46616c6b
0x46616c6b requested changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@0x46616c6b 0x46616c6b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you think about using https://github.com/goreleaser/goreleaser?

.github/workflows/ci-cd.yml Outdated Show resolved Hide resolved
.github/workflows/ci-cd.yml Outdated Show resolved Hide resolved
.github/workflows/ci-cd.yml Outdated Show resolved Hide resolved
.github/workflows/ci-cd.yml Outdated Show resolved Hide resolved
.github/workflows/ci-cd.yml Outdated Show resolved Hide resolved
.github/workflows/ci-cd.yml Outdated Show resolved Hide resolved
.github/workflows/ci-cd.yml Outdated Show resolved Hide resolved
@axdotl axdotl requested a review from 0x46616c6b July 7, 2021 07:07
0x46616c6b
0x46616c6b requested changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@0x46616c6b 0x46616c6b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check also if you using a actual Go version to build the action.

.github/workflows/ci-cd.yml Outdated Show resolved Hide resolved
.github/workflows/ci-cd.yml Outdated Show resolved Hide resolved
@axdotl axdotl requested a review from 0x46616c6b July 7, 2021 07:11
@axdotl axdotl force-pushed the DIA-1550-adjust-linter branch 6 times, most recently from cc8c34b to 0fa1165 Compare July 7, 2021 08:46
@axdotl axdotl merged commit 512bea0 into master Jul 7, 2021
@axdotl axdotl deleted the DIA-1550-adjust-linter branch July 7, 2021 08:51
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@0x46616c6b 0x46616c6b 0x46616c6b approved these changes

@ricoberger ricoberger Awaiting requested review from ricoberger

@monotek monotek Awaiting requested review from monotek

@kaitimmer kaitimmer Awaiting requested review from kaitimmer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@axdotl @0x46616c6b @kaitimmer