Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DDEX Lending Opportunity #14

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

radar-bear
Copy link

Two solidity file are added to the framework.

  • contracts/ray/external/ddex/Actions.sol
  • contracts/ray/protocol/impl/opportunities/DDEXOpportunity.sol

Following specification

contracts/ray/external/ddex/Actions.sol Outdated Show resolved Hide resolved
@dpurhar27
Copy link
Contributor

Overall feedback @radar-bear

  • Please try compiling the contracts before asking for a review.
  • I left a few questions around DDEX behaviour in different situations if you could please answer them.

@dpurhar27 dpurhar27 changed the title Add ddexOpportunity Add DDEX Lending Opportunity Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants