Mandrill Cc/Bcc handling

[Ninir]

Hi,

This adds the implementation of Cc/Bcc for Mandrill. There were 2 ways to do it, as exposed on the Mandrill API doc:

• Updating the identity to set a type, which is then parsed by Mandrill.
• Adding a bcc_address option

I found the first one more maintainable. Not sure how to handle tests in a proper way.

[Ninir]

As @stof worked on the Identity stuff, I think he could get his mind on this.

I would also add that this is an urgent work, so I will be reactive on this. Thanks for your time and patience.

[stof]

I don't see the reason to modify the Identity (thus, adding a method in IdentityInterface is a bC break).

The Mandrill adapter could simply loop over $tos, $ccs and $bccs separately instead of merging them together and then needing to distinguish where the came from.

Thus, your logic is broken: if I set an Identity object in BCC without setting its type, you will still handle it as a To (actually, even for others as you don't set the type when normalizing either) because you use the type from the identity rather than the source where they come from.

[stof]

and MandrillTest.php is testing the formatting of messages. This is the place where you should add a test using Cc and Bcc

[Ninir]

@stof At the moment, I don't have time to do a big work on this... this was a 20minutes work. Could you suggest your way to proceed? I would gladly come with a new version if I could have hints on this. Thanks.

[stof]

@Ninir the way to send the type as To, even for Bcc and Cc. This is why addign a test is important.

and for the implementation, just keep the existing loop processing To recipients, and add 2 new loops after that for Cc and Bcc

[Ninir]

@stof Added some tests to handle cases. Understood what you meant, and it's even lighter compared to what was done previously. Thanks for this.

[stof]

Postmark and Buzz should not be mentionned here actually:

• we have more HTTP adapters than Buzz (currently Guzzle3)
• we have more implementations of this interface than just Postmark

[Ninir]

Fixed the message to be more generic.

[stof]

👍

[henrikbjorn]

Thanks both :)

[stof]

@henrikbjorn it would be great to do a 0.8.0 release with this

[henrikbjorn]

This is now done https://github.com/henrikbjorn/Stampie/releases/tag/0.8.0 :)

[Ninir]

A big thank @henrikbjorn @stof :)