Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using PSR-4 #67

Merged
merged 1 commit into from
Jun 24, 2017
Merged

Using PSR-4 #67

merged 1 commit into from
Jun 24, 2017

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jun 23, 2017

No description provided.

@henrikbjorn
Copy link
Contributor

Great however, the relocation of the files arent a good idea.

@Nyholm
Copy link
Member Author

Nyholm commented Jun 23, 2017

the relocation of the files arent a good idea.

How come?

Btw, Can you enable travis, style ci etc (or make me admin)

@henrikbjorn
Copy link
Contributor

You should be an administrator now. Moving files is a BC break.

@stof
Copy link
Member

stof commented Jun 23, 2017

@henrikbjorn do you actually support the case where people require files themselves instead of relying on the autoloading configuration shipped in the package ? If yes, adding files is a BC break... Nobody tries to provide BC for people reconfiguring the autoloader themselves without using the metadata shipped in the composer.json

@Nyholm
Copy link
Member Author

Nyholm commented Jun 23, 2017

Yeah, I thought I could squeze in this minor BC break before the stable release

@stof
Copy link
Member

stof commented Jun 23, 2017

For Travis, the first issue is that the Stampie organization uses the third-party access policy, and Travis is not authorized. So it cannot put the status on the repo. It must be accepted by an organization owner (and I'm not one)

@Nyholm
Copy link
Member Author

Nyholm commented Jun 23, 2017

Correct. I think the owner got an email.

See this page: https://github.com/settings/connections/applications/f244293c729d5066cf27

@stof
Copy link
Member

stof commented Jun 23, 2017

yeah, I requested access.

@henrikbjorn
Copy link
Contributor

henrikbjorn commented Jun 23, 2017 via email

@Nyholm Nyholm modified the milestone: Release 1.0.0 Jun 23, 2017
@henrikbjorn
Copy link
Contributor

I am okay with the file rename now.

You are both now "Owners"

I have approved Scrutinizer.

@Nyholm
Copy link
Member Author

Nyholm commented Jun 23, 2017

Thank you Henrik.

I need one of you to decide and merge on this PR. Im fine either way.

IIRC Symfony went from PSR-0 to PSR-4 in a minor release.

@henrikbjorn henrikbjorn merged commit 78f324b into Stampie:master Jun 24, 2017
@Nyholm
Copy link
Member Author

Nyholm commented Jun 24, 2017

Thank you for merging

@Nyholm Nyholm deleted the psr4 branch June 24, 2017 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants