-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using PSR-4 #67
Using PSR-4 #67
Conversation
Great however, the relocation of the files arent a good idea. |
How come? Btw, Can you enable travis, style ci etc (or make me admin) |
You should be an administrator now. Moving files is a BC break. |
@henrikbjorn do you actually support the case where people require files themselves instead of relying on the autoloading configuration shipped in the package ? If yes, adding files is a BC break... Nobody tries to provide BC for people reconfiguring the autoloader themselves without using the metadata shipped in the composer.json |
Yeah, I thought I could squeze in this minor BC break before the stable release |
For Travis, the first issue is that the Stampie organization uses the third-party access policy, and Travis is not authorized. So it cannot put the status on the repo. It must be accepted by an organization owner (and I'm not one) |
Correct. I think the owner got an email. See this page: https://github.com/settings/connections/applications/f244293c729d5066cf27 |
yeah, I requested access. |
Ill give both of you owner when i get home :)
fre. 23. jun. 2017 kl. 16.04 skrev Christophe Coevoet <
notifications@github.com>:
… yeah, I requested access.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#67 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABNDX71A-YVnhVgjgnPCa7WbGuHzd9Kks5sG8XYgaJpZM4ODlKM>
.
|
I am okay with the file rename now. You are both now "Owners" I have approved Scrutinizer. |
Thank you Henrik. I need one of you to decide and merge on this PR. Im fine either way. IIRC Symfony went from PSR-0 to PSR-4 in a minor release. |
Thank you for merging |
No description provided.