Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade button in user settings #1484

Merged
merged 5 commits into from
Oct 25, 2023

Conversation

matthieujacq
Copy link
Contributor

@matthieujacq matthieujacq commented Oct 25, 2023

Description

Epic: #1429
User Story: #1431

  • Add an upgrade button in user settings.
  • Remove hover links on sidebar buttons (otherwise the link could partially hide the button)

Screenshots (if appropriate):

image image

@matthieujacq matthieujacq self-assigned this Oct 25, 2023
@matthieujacq matthieujacq temporarily deployed to preview October 25, 2023 08:00 — with GitHub Actions Inactive
@dosubot dosubot bot added the area: frontend Related to frontend functionality or under the /frontend directory label Oct 25, 2023
@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 10:42am
quivr-strapi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 10:42am
quivrapp ❌ Failed (Inspect) Oct 25, 2023 10:42am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/user/page.tsx

The is_premium variable is used before it is defined. This could potentially lead to a ReferenceError if userData is undefined or null. Consider moving the definition of is_premium after the check for session.

if (!session) {
  redirectToLogin();
}

const { userData } = useUserData();
const is_premium = userData?.is_premium;

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/lib/components/Sidebar/components/SidebarFooter/components/SidebarFooterButton.tsx

The onClick prop is being overwritten if href is defined. This could lead to unexpected behavior if a parent component passes an onClick prop. Consider calling both functions if both href and onClick are defined.

if (href !== undefined) {
  const originalOnClick = onClick;
  onClick = () => {
    void router.push(href);
    originalOnClick?.();
  };
}

🚧🔍🐛


Powered by Code Review GPT

@matthieujacq matthieujacq merged commit ee7af51 into main Oct 25, 2023
10 of 11 checks passed
mamadoudicko pushed a commit that referenced this pull request Oct 26, 2023
🤖 I have created a release *beep* *boop*
---


## 0.0.98 (2023-10-26)

## What's Changed
* feat: upgrade button in user settings by @matthieujacq in
#1484
* fix: failing build (removed avatar alt prop) by @matthieujacq in
#1487
* Fixed license link in intro.md by @Eric013 in
#1486
* feat: manage plan by @matthieujacq in
#1488
* feat: remove feature flags for homepage by @matthieujacq in
#1493
* feat: add new signin/login page by @mamadoudicko in
#1492

## New Contributors
* @Eric013 made their first contribution in
#1486

**Full Changelog**:
v0.0.97...v0.0.98

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
coolCatalyst added a commit to coolCatalyst/quivr that referenced this pull request Jun 1, 2024
🤖 I have created a release *beep* *boop*
---


## 0.0.98 (2023-10-26)

## What's Changed
* feat: upgrade button in user settings by @matthieujacq in
QuivrHQ/quivr#1484
* fix: failing build (removed avatar alt prop) by @matthieujacq in
QuivrHQ/quivr#1487
* Fixed license link in intro.md by @Eric013 in
QuivrHQ/quivr#1486
* feat: manage plan by @matthieujacq in
QuivrHQ/quivr#1488
* feat: remove feature flags for homepage by @matthieujacq in
QuivrHQ/quivr#1493
* feat: add new signin/login page by @mamadoudicko in
QuivrHQ/quivr#1492

## New Contributors
* @Eric013 made their first contribution in
QuivrHQ/quivr#1486

**Full Changelog**:
QuivrHQ/quivr@v0.0.97...v0.0.98

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Dream528 added a commit to Dream528/quivr that referenced this pull request Jul 28, 2024
🤖 I have created a release *beep* *boop*
---


## 0.0.98 (2023-10-26)

## What's Changed
* feat: upgrade button in user settings by @matthieujacq in
QuivrHQ/quivr#1484
* fix: failing build (removed avatar alt prop) by @matthieujacq in
QuivrHQ/quivr#1487
* Fixed license link in intro.md by @Eric013 in
QuivrHQ/quivr#1486
* feat: manage plan by @matthieujacq in
QuivrHQ/quivr#1488
* feat: remove feature flags for homepage by @matthieujacq in
QuivrHQ/quivr#1493
* feat: add new signin/login page by @mamadoudicko in
QuivrHQ/quivr#1492

## New Contributors
* @Eric013 made their first contribution in
QuivrHQ/quivr#1486

**Full Changelog**:
QuivrHQ/quivr@v0.0.97...v0.0.98

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: frontend Related to frontend functionality or under the /frontend directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants