Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix in-video quiz question issues with display, sizing, and alignment #11

Merged
merged 5 commits into from
May 16, 2017
Merged

Fix in-video quiz question issues with display, sizing, and alignment #11

merged 5 commits into from
May 16, 2017

Commits on May 16, 2017

  1. Fix in-video quiz question misalignment when video isn't first component 

    If a video isn't the first component in the unit, the in-video-quiz
questions appear incorrectly positioned on the page. We reposition
the questions to properly cover the video while it's paused.
    @karandikar
    karandikar committed May 16, 2017
    Configuration menu
    Copy the full SHA
    372c75c View commit details
    Browse the repository at this point in the history

  2. Fix issue with in-video quiz problem display css property 

    Previously, questions would sometimes fail to display in the in-video quiz
xblocks. This was likely due to the "display" css property not changing
from "none" to "block" for the problem component. This would also trigger
issues with the videoState variable as well.
    @karandikar
    karandikar committed May 16, 2017
    Configuration menu
    Copy the full SHA
    477af42 View commit details
    Browse the repository at this point in the history

  3. Fix in-video-quiz questions not resizing when video is resized 

    Previously, if the video transitioned from fullscreen to regular size
with a question open, or if the window was resized with a question open,
the question would not resize properly (the position, height, and/or width
would be incorrect). This commit checks for changes to the video dimensions
every 100ms when a question is open, and resizes the question if a change
is detected.
    @karandikar
    karandikar committed May 16, 2017
    Configuration menu
    Copy the full SHA
    1fbb911 View commit details
    Browse the repository at this point in the history

  4. Fix stylistic issues with javascript 

    - Rename ambiguous interval and timeout variables
- Rename functions to reduce verbosity
- Switch data structure for video dimension to be dictionary instead of list
- Remove unnecessary comment
    @karandikar
    karandikar committed May 16, 2017
    Configuration menu
    Copy the full SHA
    8abbbd6 View commit details
    Browse the repository at this point in the history

  5. Bump release patch version from 0.1.4 to 0.1.5

    @karandikar
    karandikar committed May 16, 2017
    Configuration menu
    Copy the full SHA
    20d2a26 View commit details
    Browse the repository at this point in the history