Move cached data from body to seq_content #20
Conversation
Previously, some future update or rogue script could easily tamper with our cached data attributes on the body element. We moved these data attributes to be slightly less widely accessible.
|
Changes Unknown when pulling f8dcce1 on potsui:change-cache-selector into ** on Stanford-Online:master**. |
| @@ -6,6 +6,7 @@ function SubmitAndCompareXBlockInitView(runtime, element) { | |||
| var publishUrl = runtime.handlerUrl(element, 'publish_event'); | |||
|
|
|||
| var $element = $(element); | |||
There was a problem hiding this comment.
can you add a separate commit that outdents these two variable definitions?
There was a problem hiding this comment.
cause those two are weirdly indented?
There was a problem hiding this comment.
Oh, weird. It looks fine here, but is off on other views.
It looks like the original author (someone at OLI)
used hard-tabs there.
If @potsui wants to include it as a separate commit, that's fine.
If not, we can merge without though.
There was a problem hiding this comment.
Please bump patch version of xblock (in this xblock I think it's only in setup.py, @caseylitton ?).
|
Killer! |
|
Changes Unknown when pulling 1a1f1bc on potsui:change-cache-selector into ** on Stanford-Online:master**. |
@stvstnfrd @caesar2164 PR for moving cached data out of
<body>Previously, some future update or rogue script could easily tamper with
our cached data attributes on the body element. We moved these data
attributes to be slightly less widely accessible.
Arose from our convo w/ free text response: Stanford-Online/xblock-free-text-response#21
Trello: https://trello.com/c/QB46SgTN/954-move-cached-data-from-body-element-to-seqcontent-for-submit-and-compare-xblcok
CC @jspayd @jlikhuva