Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some aha commands to run glb-fabric test and change pointer to h2h, garnet, clockwork submodules #1277

Merged
merged 34 commits into from
Jul 25, 2021

Conversation

kongty
Copy link
Contributor

@kongty kongty commented Jul 2, 2021

Update some aha commands to run glb-fabric test and change pointer to h2h, garnet, clockwork submodules

Copy link
Contributor

@jeffsetter jeffsetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jeffsetter
Copy link
Contributor

It would be nice if aha glb didn't output so many lines to stdout. It is causing the buildkite to truncate the log.

@kongty
Copy link
Contributor Author

kongty commented Jul 2, 2021

It would be nice if aha glb didn't output so many lines to

Done. It only dumps wrong pixels now.

@joyliu37
Copy link
Contributor

joyliu37 commented Jul 8, 2021

The changes look good to me. I am not sure if you could resolve that merge conflicts. Maybe that pop up in the recent days.

Copy link
Contributor

@jeffsetter jeffsetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kongty kongty merged commit 2bf853e into master Jul 25, 2021
@kongty kongty deleted the glb-meta branch July 25, 2021 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants