Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CollectSamples Option for the HealthKit Module #57

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

PSchmiedmayer
Copy link
Member

Add CollectSamples Option for the HealthKit Module

♻️ Current situation & Problem

  • The CardinalKit HealthKit Module currently only supports adding an individual HealthKit type per configuration closure.

💡 Proposed solution

  • This PR adds the CollectSamples option to specify multiple HealthKit permission types for the HealthKit Module.

Testing

  • The current UI tests cover all the uses cases as the CollectSample type now uses the CollectSamples type in the background.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #57 (ef4f8c8) into main (441f82c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   66.97%   66.97%           
=======================================
  Files          53       53           
  Lines        1468     1468           
=======================================
  Hits          983      983           
  Misses        485      485           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 441f82c...ef4f8c8. Read the comment docs.

@PSchmiedmayer PSchmiedmayer merged commit 6162a67 into main Mar 7, 2023
@PSchmiedmayer PSchmiedmayer deleted the feature/healthKitImprovements branch March 7, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant