Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Observation+Dates.swift so that start and end dates are correct #36

Merged
merged 4 commits into from
Jun 30, 2023

Conversation

mjoerke
Copy link
Contributor

@mjoerke mjoerke commented Jun 30, 2023

Update Observation+Dates.swift so that start and end dates are correct

♻️ Current situation & Problem

  • In Observation+Dates.swift the start and end dates are swapped

💡 Proposed solution

  • Minor edits to Observation+Dates.swift so that start and end dates are set correctly

⚙️ Release Notes

  • This does not change any functionality and should not be a breaking change

Testing

  • I did not include any additional tests (but let me know if you think this is necessary)

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

The start and end dates are swapped in the current implementation
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the fix @mjoerke! 🚀

@PSchmiedmayer PSchmiedmayer enabled auto-merge (squash) June 30, 2023 19:15
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #36 (ab9f896) into main (354c180) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage   92.12%   92.12%           
=======================================
  Files          20       20           
  Lines         875      875           
=======================================
  Hits          806      806           
  Misses         69       69           
Impacted Files Coverage Δ
...HIR/Observation Extensions/Observation+Dates.swift 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 354c180...ab9f896. Read the comment docs.

@PSchmiedmayer PSchmiedmayer merged commit fdf8e45 into StanfordBDHG:main Jun 30, 2023
10 checks passed
@PSchmiedmayer PSchmiedmayer deleted the patch-1 branch June 30, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants