Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure compatibility with C++ interoperability in Swift #12

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Jan 25, 2024

Ensure compatibility with C++ interoperability in Swift

♻️ Current situation & Problem

Currently, ResearchKit fails to build when you have a project that enables C++ interoperability in Swift. This PR addresses these issues with some minor code changes.

⚙️ Release Notes

  • Ensure compatibility with C++ interoperability in Swift

📚 Documentation

--

✅ Testing

Manually verified that SpeziQuestionnaire builds and tests with these changes (with and without C++ interoperability enabled).

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Supereg, amazing that you figured this out!!

@Supereg
Copy link
Member Author

Supereg commented Jan 25, 2024

@PSchmiedmayer Seems like the build actions changed their name(?). Could you adjust the branch protection CI requirements?

@Supereg
Copy link
Member Author

Supereg commented Jan 25, 2024

I documented the need to verify this in CI within #13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants