Compile Tests & Improve Availability #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
What was the reason to increase the minimum deployment target here? Is there anything that is functionally different? |
1 task
|
Yes, any iOS API that was deprecated before iOS 14 won't be available on visionOS so I pulled it up from the original RK deployment target. We could even pull it up or down further as needed. I looked at the number of warnings and tried to pull it up as much as possible before I got a lot of warnings. |
Supereg
added a commit
that referenced
this pull request
Feb 23, 2024
# Disable SensorKit support by default ## ♻️ Current situation & Problem As discussed in #17, SensorKit is not available on iPadOS even though it is annotated to be available. This results SensorKit being linked for iOS but the app crashing when run on iPad as the framework cannot be dynamically linked. This issue was induced due to the change in #16 that raised the deployment target to iOS 15. Even conditionally importing SensorKit does not work as it is reported to be available for iPadOS to the compiler. This PR disables SensorKit integration by default, controlled via the `USE_SENSOR_KIT` macro. While the `ORKSensorPermissionType` is still there it shows up as unavailable for the platform in ResearchKit UI. ## ⚙️ Release Notes * Fixed crash on iPadOS by disabling SensorKit integration by default. ## 📚 Documentation -- ## ✅ Testing Verified locally. ### Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compile Tests & Improve Availability
⚙️ Release Notes
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: