Support output directories for active tasks #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
PSchmiedmayer
approved these changes
Mar 5, 2024
Supereg
added a commit
that referenced
this pull request
Mar 5, 2024
…21) # Fix access to UIWindow when delegate doesn't implement that property ## ♻️ Current situation & Problem Currently, ResearchKit assumes that the `window` property is implemented by every `UIApplicationDelegate`. However, if you refer to the documentation of [window](https://developer.apple.com/documentation/uikit/uiapplicationdelegate/1623056-window) the property is only required if you are using UIKit with Storyboard files. The automatic synthesis the documentation refers to doesn't seem to work according to our experience. This issue impacted, e.g., CS342/2024-PICS#43. This PR fixes this issue by checking first, if the respective delegate instance responds to the window selector. This PR also addresses an issue in the CI setup where artifact names where not unique and therefore failed the CI run. ## ⚙️ Release Notes * Fixes a crash where `window` is not implemented for an UIApplicationDelegate. ## 📚 Documentation -- ## ✅ Testing This will be verified within #20. However, the PR requires to compiled ResearchKit xcfamework first. ### Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md).
Supereg
force-pushed
the
feature/output-directory
branch
from
ff5006f
to
ab05a68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support output directories for active tasks
♻️ Current situation & Problem
Currently, there is no way to specify an output directory for ResearchKit tasks that require an output directory. This PR automatically creates a temporary directory and deletes it after the task result got delivered.
⚙️ Release Notes
📚 Documentation
A Documentation tip was added to document the behavior.
✅ Testing
TBA
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: