Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hwloc-2.0 support #575

Open
keszybz opened this issue Aug 25, 2019 · 9 comments
Open

hwloc-2.0 support #575

keszybz opened this issue Aug 25, 2019 · 9 comments
Assignees
Labels
backlog Feature/fix that is desirable, but not currently planned enhancement good first issue Feature/fix that does not require in-depth Legion knowledge help wanted Looking for somebody to work on this - we'll help you get started! Realm Issues pertaining to Realm

Comments

@keszybz
Copy link

keszybz commented Aug 25, 2019

Hi,
mpich 3.3 now requires hwloc>=2.0. It would be great if legion could be updated too.
This was already signalled in #479 in February :(

@streichler streichler self-assigned this Aug 25, 2019
@streichler streichler added enhancement Realm Issues pertaining to Realm labels Aug 25, 2019
@streichler
Copy link
Contributor

Yes, this is somewhere on our task list. It's not super-high though, as you can almost
certainly disable hwloc in the Legion/Realm build with no loss of functionality. (Or
conversely, if you have a system that the linux-sysfs-based discovery code doesn't work
as well as hwloc for, let me know and we'll consider bumping this up the priority list.)

@keszybz
Copy link
Author

keszybz commented Aug 25, 2019

Thanks for the quick reply. I made a small patch to fix one of the two compilation issues.
I also did the suggested thing and disabled the use of hwloc that does not compile...

Or conversely, if you have a system that the linux-sysfs-based discovery code doesn't work
as well as hwloc for, let me know and we'll consider bumping this up the priority list.

I wish I knew ;) I'm just the packager here, and I'm only touching legion because I want to update mpich.

@streichler streichler added backlog Feature/fix that is desirable, but not currently planned good first issue Feature/fix that does not require in-depth Legion knowledge help wanted Looking for somebody to work on this - we'll help you get started! labels Sep 24, 2019
@streichler
Copy link
Contributor

As mentioned in the pull request, I'd like this change to add hwloc-2.x support without losing hwloc-1.x support, so it'll all need to be ifdef-protected.

@ghost
Copy link

ghost commented Dec 11, 2021

Still waiting for update to hwloc-2.6.0

@ghost
Copy link

ghost commented Dec 11, 2021

If you have any patch please provide it as I could add it to gentoo ebuild

@streichler
Copy link
Contributor

@scardracs As was suggested a while back, I think the simplest thing to do here is to remove the Legion package's dependence on hwloc entirely. We routinely build without hwloc in our development, so I'm not sure what the issue that @keszybz encountered before was. If you're not sure how to disable use of hwloc in Legion, please point me at your build script and I'll see if I can suggest something.

@ghost
Copy link

ghost commented Dec 13, 2021

@scardracs As was suggested a while back, I think the simplest thing to do here is to remove the Legion package's dependence on hwloc entirely. We routinely build without hwloc in our development, so I'm not sure what the issue that @keszybz encountered before was. If you're not sure how to disable use of hwloc in Legion, please point me at your build script and I'll see if I can suggest something.

Yeah I know how to remove it, the only point is that Gentoo ebuild use +hwloc, which means is forced by default. If you prefer to remove it I can proceed on dropping it on Gentoo side (as I'm working on cleanup/maintain it)

@streichler
Copy link
Contributor

I'm not that familiar with Gentoo's build system, but having Legion's use of hwloc be disabled by default sounds better to me.

@ghost
Copy link

ghost commented Dec 14, 2021

I'm not that familiar with Gentoo's build system, but having Legion's use of hwloc be disabled by default sounds better to me.

Short answer:

Gentoo uses ebuilds, which use a list of flags (IUSE). On legion there is a IUSE="... +hwloc ..." and that means it is forced by default if not disabled system-wide. I'm gonna drop it this evening.

gentoo-bot pushed a commit to gentoo/gentoo that referenced this issue Dec 26, 2021
Doesn't build with newer versions right now and it looks like
(not being an expert in cluster stuff at all, to be fair)
hwloc isn't super important here from the upstream comments
(there's alternatives available which are used by default).

Bug: StanfordLegion/legion#575
Bug: https://bugs.gentoo.org/796128
Signed-off-by: Sam James <sam@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Feature/fix that is desirable, but not currently planned enhancement good first issue Feature/fix that does not require in-depth Legion knowledge help wanted Looking for somebody to work on this - we'll help you get started! Realm Issues pertaining to Realm
Projects
None yet
Development

No branches or pull requests

2 participants