Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Additional Lifecycle Methods #62

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Conversation

PSchmiedmayer
Copy link
Member

Add Additional Lifecycle Methods

♻️ Current situation & Problem

💡 Proposed solution

  • Extends the LifecycleHandler infrastructure to support additional lifecycle handlers including:
    • func applicationDidBecomeActive(_ application: UIApplication)
    • func applicationWillResignActive(_ application: UIApplication)
    • func applicationDidEnterBackground(_ application: UIApplication)
    • func applicationWillEnterForeground(_ application: UIApplication)

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #62 (6ae5faf) into main (4672266) will decrease coverage by 4.94%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
- Coverage   94.32%   89.38%   -4.94%     
==========================================
  Files          52       29      -23     
  Lines        1408      593     -815     
==========================================
- Hits         1328      530     -798     
+ Misses         80       63      -17     
Impacted Files Coverage Δ
...dule/Capabilities/Lifecycle/LifecycleHandler.swift 100.00% <100.00%> (ø)
...pabilities/Lifecycle/Spezi+LifecycleHandlers.swift 100.00% <100.00%> (ø)
Sources/Spezi/Spezi/SpeziAppDelegate.swift 95.84% <100.00%> (+4.17%) ⬆️

... and 28 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4672266...6ae5faf. Read the comment docs.

@PSchmiedmayer PSchmiedmayer merged commit 57ddc03 into main Jun 7, 2023
7 checks passed
@PSchmiedmayer PSchmiedmayer deleted the feature/lifecycle branch June 7, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant