Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LifecycleHandler to Use Scene Methods #67

Merged
merged 4 commits into from
Jun 27, 2023
Merged

Update LifecycleHandler to Use Scene Methods #67

merged 4 commits into from
Jun 27, 2023

Conversation

PSchmiedmayer
Copy link
Member

Update LifecycleHandler to Use Scene Methods

♻️ Current situation & Problem

  • The current Lifecycle methods in the Spezi LifecycleHandlers are not properly called and do not reflect the latest advancements on iOS to use the UISceneDelegate

💡 Proposed solution

  • Deprecates the current application lifecycle methods in favor for scene-related methods
  • Adds tests to test the lifecycle methods

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #67 (a81cb2c) into main (57ddc03) will increase coverage by 0.30%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   89.38%   89.68%   +0.30%     
==========================================
  Files          29       29              
  Lines         593      610      +17     
==========================================
+ Hits          530      547      +17     
  Misses         63       63              
Impacted Files Coverage Δ
...dule/Capabilities/Lifecycle/LifecycleHandler.swift 100.00% <100.00%> (ø)
...pabilities/Lifecycle/Spezi+LifecycleHandlers.swift 100.00% <100.00%> (ø)
Sources/Spezi/Spezi/SpeziAppDelegate.swift 96.56% <100.00%> (+0.72%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57ddc03...a81cb2c. Read the comment docs.

@PSchmiedmayer PSchmiedmayer merged commit 0e070d9 into main Jun 27, 2023
7 checks passed
@PSchmiedmayer PSchmiedmayer deleted the scene branch June 27, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant