Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Deprecated Methods #74

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Remove Deprecated Methods #74

merged 1 commit into from
Jul 20, 2023

Conversation

PSchmiedmayer
Copy link
Member

Remove Deprecated Methods

♻️ Current situation & Problem

  • We have a few deprecated methods that we can remove with the next major version that we will tag after this release.

💡 Proposed solution

  • Remove the methods.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #74 (def9946) into main (d02b67a) will increase coverage by 6.68%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
+ Coverage   88.83%   95.50%   +6.68%     
==========================================
  Files          44       34      -10     
  Lines         743      600     -143     
==========================================
- Hits          660      573      -87     
+ Misses         83       27      -56     
Impacted Files Coverage Δ
...pabilities/Lifecycle/Spezi+LifecycleHandlers.swift 100.00% <ø> (ø)
...s/ObservableObject/ObservableObjectComponent.swift 86.37% <ø> (ø)
...ies/ObservableObject/Spezi+ObservableObjects.swift 100.00% <ø> (ø)
Sources/Spezi/Component/Component.swift 100.00% <ø> (ø)
Sources/Spezi/Spezi/Spezi.swift 94.45% <ø> (-0.29%) ⬇️
...pezi/Capabilities/Lifecycle/LifecycleHandler.swift 100.00% <100.00%> (ø)
Sources/Spezi/Component/ComponentBuilder.swift 100.00% <100.00%> (ø)
Sources/Spezi/Component/ComponentCollection.swift 100.00% <100.00%> (ø)
Sources/Spezi/Configuration/Configuration.swift 100.00% <100.00%> (ø)
...rces/Spezi/Dependencies/DependencyDescriptor.swift 100.00% <100.00%> (ø)
... and 6 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7c6b1e...def9946. Read the comment docs.

@PSchmiedmayer PSchmiedmayer merged commit c98b2e5 into main Jul 20, 2023
9 checks passed
@PSchmiedmayer PSchmiedmayer deleted the removeDepricatedMethods branch July 20, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant