Support iteration in builtin SharedRepository implementations #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
+ Coverage 97.52% 97.63% +0.11%
==========================================
Files 34 34
Lines 604 631 +27
==========================================
+ Hits 589 616 +27
Misses 15 15
Continue to review full report in Codecov by Sentry.
|
PSchmiedmayer
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support iteration in builtin SharedRepository implementations
♻️ Current situation & Problem
Currently, we have no ability to access the elements in our built in shared repositories in a type-erased way. Specifically, we have no way to iterate over them.
💡 Proposed solution
This PR addresses this issue by adding
Collectionconformance for our two builtin Shared Repository types and extending theAnyRepositoryValuetype.⚙️ Release Notes
Collectionconformance to our build in shared repositories.➕ Additional Information
Related PRs
This feature will be useful in StanfordSpezi/SpeziAccount#7 for a Account Service to process modified account details.
Testing
Additionally unit tests were included.
Reviewer Nudging
--
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: