Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Documentation in Conformance to the Documentation Guide #17

Merged
merged 17 commits into from
Oct 8, 2023

Conversation

vishnuravi
Copy link
Member

@vishnuravi vishnuravi commented Sep 21, 2023

Update Documentation in Conformance to the Documentation Guide

♻️ Current situation & Problem

Addresses #11.

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #17 (95a2e29) into main (2d2b809) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #17   +/-   ##
=======================================
  Coverage   80.07%   80.07%           
=======================================
  Files           5        5           
  Lines         311      311           
=======================================
  Hits          249      249           
  Misses         62       62           
Files Coverage Δ
...urces/SpeziContact/Contact Views/ContactView.swift 81.35% <ø> (ø)
...rces/SpeziContact/Contact Views/ContactsList.swift 51.86% <ø> (ø)
Sources/SpeziContact/Models/Contact.swift 100.00% <ø> (ø)
Sources/SpeziContact/Models/ContactOption.swift 86.16% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d2b809...95a2e29. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great documentation improvements and added examples, great appreciated @vishnuravi!

I fixed some smaller issues around dark mode and wordings so we don't need an other feedback loop. Feel free to merge the PR and tag a new release once you are happy with all the changes 🚀

@vishnuravi vishnuravi merged commit 9dea670 into main Oct 8, 2023
7 checks passed
@vishnuravi vishnuravi deleted the documentation branch October 8, 2023 19:27
@PSchmiedmayer PSchmiedmayer added the documentation Improvements or additions to documentation label Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants