Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Spelling Fix #10

Merged
merged 1 commit into from Mar 2, 2024
Merged

Conversation

kcallon
Copy link
Contributor

@kcallon kcallon commented Mar 1, 2024

Small Spelling Fix

♻️ Current situation & Problem

I noticed when using MedicationSettings that "allowEmptySave" was spelled "allowEmtpySave".

⚙️ Release Notes

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix @kcallon, nice that you noticed that!

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.04%. Comparing base (95ca9ae) to head (bf72617).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage   52.04%   52.04%           
=======================================
  Files          21       21           
  Lines         982      982           
=======================================
  Hits          511      511           
  Misses        471      471           
Files Coverage Δ
Sources/SpeziMedication/MedicationSettings.swift 88.58% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95ca9ae...bf72617. Read the comment docs.

@PSchmiedmayer PSchmiedmayer merged commit f5e284d into StanfordSpezi:main Mar 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants