-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content adjustment for upcoming onboarding steps #46
Content adjustment for upcoming onboarding steps #46
Conversation
Motivation: Closes StanfordSpezi#44. `OnboardingStack` only allowed modifications to its views (i.e. order and content of the `OnboardingStack`) when the onboarding process was at its first step (i.e. no navigation operations have occured). We want to loosen this restriction by allowing modifications to all views that are ahead of the current onboarding step. Modifications: * `OnboardingNavigationPath.updateViews`: update all views that are ahead of current onboarding step instead of only updating views on the first onboarding step
@felixschlegel Thanks for the PR; it looks quite straightforward already! 🚀 One random thought: We probably should get rid of "duplicate" |
Modifications: * `TestApp`: add new `OnboardingCustomToggleTestView` to change state of `showConditionalView` when already progressed in the `OnboardingStack` * add new test case `testDynamicOnboardingFlow3()` that clicks through the onboarding process and changes `showConditionalView` in `OnboardingCustomToggleTestView` before onboarding is completed
Modifications: * `Package.swift`: add dependency to `apple/swift-collections` * `OnboardingNavigationPath`: merge `onboardingSteps` and `onboardingStepsOrder` into one using a `swift-collections` `OrderedDictionary`
Great point! Have adjusted the code accordingly. Furthermore, I added a new UI Test assuring that steps ahead of the current onboarding steps can be modified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@felixschlegel Thank you for the improvements; the changes look great to me. Thanks for adding the UI tests. Let me know once you think that we can merge the PR.
We have some unfortunate issues with codecov and are evaluating how we will continue with the tool beyond the issues here. I can merge the PR with admin permissions once you think it is complete 👍
I have nothing to add, if you like, we can merge 👍 |
Content adjustment for upcoming onboarding steps
♻️ Current situation & Problem
Closes #44.
OnboardingStack
only allowed modifications to its views (i.e. order and content of theOnboardingStack
) when the onboarding process was at its first step (i.e. no navigation operations have occurred). We want to loosen this restriction by allowing modifications to all views that are ahead of the current onboarding step.⚙️ Release Notes
OnboardingNavigationPath.updateViews
: update all views that are ahead of current onboarding step instead of only updating views on the first onboarding step📚 Documentation
✅ Testing
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: