Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Timed Walk Test & Improve Rendering Possibilities for the QuestionnaireView #16

Merged
merged 32 commits into from Mar 10, 2024

Conversation

dguo8412
Copy link
Contributor

@dguo8412 dguo8412 commented Oct 3, 2023

Add Timed Walk Test & Improve Rendering Possibilities for the QuestionnaireView

⚙️ Release Notes

  • Adds the TimedWalkTestView
  • Adds the cancellation configuration to the QuestionnaireView

📚 Documentation

  • Adds documentation for all code changes.

✅ Testing

  • Adds automated tests for the timed walk test.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the first draft! I added some comments and suggestions on how to approach the generalization in individual comments as the review 👍

Sources/SpeziQuestionnaire/ORKOrderedTaskView.swift Outdated Show resolved Hide resolved
Sources/SpeziQuestionnaire/QuestionnaireConstraint.swift Outdated Show resolved Hide resolved
Sources/SpeziQuestionnaire/TimedWalkView.swift Outdated Show resolved Hide resolved
Sources/SpeziQuestionnaire/TimedWalkView.swift Outdated Show resolved Hide resolved
Sources/SpeziQuestionnaire/TimedWalkView.swift Outdated Show resolved Hide resolved
Tests/UITests/UITests.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.45%. Comparing base (f25580e) to head (fc88f66).

❗ Current head fc88f66 differs from pull request most recent head 9be97d8. Consider uploading reports for the commit 9be97d8 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #16   +/-   ##
=======================================
  Coverage   84.45%   84.45%           
=======================================
  Files           1        1           
  Lines          45       45           
=======================================
  Hits           38       38           
  Misses          7        7           
Files Coverage Δ
Sources/SpeziQuestionnaire/QuestionnaireView.swift 84.45% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f25580e...9be97d8. Read the comment docs.

@PSchmiedmayer PSchmiedmayer added the enhancement New feature or request label Oct 11, 2023
@PSchmiedmayer
Copy link
Member

@dguo8412 Thank you for all the work here! Feel free to tag me for an other review once you have finished the UI tests and addressed all other red warnings. Great to see the progress in this PR and to have you in the office to work on it! 👍

@PSchmiedmayer PSchmiedmayer changed the title Abstract functionality for timedWalk and other researchkit tasks Add Timed Walk Test & Improve Rendering Possibilities for the QuestionnaireView Mar 10, 2024
@PSchmiedmayer PSchmiedmayer changed the title Add Timed Walk Test & Improve Rendering Possibilities for the QuestionnaireView Add Timed Walk Test & Improve Rendering Possibilities for the QuestionnaireView Mar 10, 2024
@PSchmiedmayer PSchmiedmayer merged commit f9d9b6d into main Mar 10, 2024
5 checks passed
@PSchmiedmayer PSchmiedmayer deleted the daniel/timed-walk branch March 10, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants