Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS Keychain support #19

Merged
merged 7 commits into from Mar 7, 2024
Merged

Fix macOS Keychain support #19

merged 7 commits into from Mar 7, 2024

Conversation

philippzagar
Copy link
Member

@philippzagar philippzagar commented Mar 6, 2024

Fix macOS Keychain support

♻️ Current situation & Problem

As of now, the LocalStorage and SecureStorage doesn't properly work on macOS as one requires additional keychain settings and entitlements.

⚙️ Release Notes

  • Fix macOS platform support by adding proper entitlements and attributes to keychain queries

📚 Documentation

Added docs for entitlements and keychain queries

✅ Testing

UI tests are passing

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@philippzagar philippzagar added the bug Something isn't working label Mar 6, 2024
@philippzagar philippzagar self-assigned this Mar 6, 2024
@philippzagar philippzagar changed the title Fix macOS support Fix macOS Keychain support Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.06%. Comparing base (eaed222) to head (43e93b7).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   91.65%   92.06%   +0.41%     
==========================================
  Files           6        6              
  Lines         431      453      +22     
==========================================
+ Hits          395      417      +22     
  Misses         36       36              
Files Coverage Δ
Sources/SpeziSecureStorage/SecureStorage.swift 93.97% <100.00%> (+0.64%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d1c8ff...43e93b7. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice; thank you for the fix on macOS 🚀

@philippzagar philippzagar merged commit b958df9 into main Mar 7, 2024
18 checks passed
@philippzagar philippzagar deleted the feat/fix-macos-support branch March 7, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants