New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix macOS Keychain support #19
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
==========================================
+ Coverage 91.65% 92.06% +0.41%
==========================================
Files 6 6
Lines 431 453 +22
==========================================
+ Hits 395 417 +22
Misses 36 36
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice; thank you for the fix on macOS 🚀
Fix macOS Keychain support
♻️ Current situation & Problem
As of now, the
LocalStorage
andSecureStorage
doesn't properly work on macOS as one requires additional keychain settings and entitlements.⚙️ Release Notes
📚 Documentation
Added docs for entitlements and keychain queries
✅ Testing
UI tests are passing
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: