Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularization #16

Merged
merged 6 commits into from
Apr 18, 2023
Merged

Modularization #16

merged 6 commits into from
Apr 18, 2023

Conversation

PSchmiedmayer
Copy link
Member

@PSchmiedmayer PSchmiedmayer commented Apr 17, 2023

Modularization

♻️ Current situation & Problem

  • The current template application uses the CardinalKit version 0.3.X which contains all dependencies in a single Swift Package.
  • The mock upload tab does not allow a navigation to the detail screens.

💡 Proposed solution

  • This PR splits out the modules in individual Swift Packages (https://swiftpackageindex.com/StanfordBDHG) and simplifies the dependency resolution by bundling all files in single Xcode project package.
  • Improves the navigation hierarchy of the mock upload tab.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #16 (de9e940) into main (9ce70e4) will decrease coverage by 2.25%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   90.56%   88.31%   -2.25%     
==========================================
  Files          24       26       +2     
  Lines         625      650      +25     
==========================================
+ Hits          566      574       +8     
- Misses         59       76      +17     
Impacted Files Coverage Δ
...ication/Helper/CodableArray+RawRepresentable.swift 42.86% <ø> (ø)
...cation/Onboarding/AccountSetup/TemplateLogin.swift 0.00% <0.00%> (ø)
TemplateApplication/Onboarding/Consent.swift 0.00% <0.00%> (ø)
...ateApplication/Onboarding/InterestingModules.swift 100.00% <ø> (ø)
TemplateApplication/Onboarding/Welcome.swift 100.00% <ø> (ø)
...ateApplication/Schedule/Bundle+Questionnaire.swift 66.67% <ø> (ø)
TemplateApplication/Schedule/EventContext.swift 50.00% <ø> (ø)
...emplateApplication/Schedule/EventContextView.swift 100.00% <ø> (ø)
TemplateApplication/TemplateAppTestingSetup.swift 100.00% <ø> (ø)
TemplateApplication/TemplateApplication.swift 100.00% <ø> (ø)
... and 16 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ce70e4...de9e940. Read the comment docs.

@PSchmiedmayer PSchmiedmayer enabled auto-merge (squash) April 18, 2023 10:32
@PSchmiedmayer PSchmiedmayer merged commit 90cc001 into main Apr 18, 2023
6 checks passed
@PSchmiedmayer PSchmiedmayer deleted the modularization branch April 18, 2023 11:16
NikolaiMadlener pushed a commit to NikolaiMadlener/SpeziTemplateApplication that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants