Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Notification Support #25

Merged
merged 14 commits into from
Jun 30, 2023
Merged

Add Notification Support #25

merged 14 commits into from
Jun 30, 2023

Conversation

PSchmiedmayer
Copy link
Member

Add Notification Support

💡 Proposed solution

  • Adds support for Notifications in the Template Application
  • Improve code reuse in the onboarding flow

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #25 (8810539) into main (a31c92f) will decrease coverage by 3.88%.
The diff coverage is 96.78%.

❗ Current head 8810539 differs from pull request most recent head 459e199. Consider uploading reports for the commit 459e199 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
- Coverage   87.29%   83.40%   -3.88%     
==========================================
  Files          27       28       +1     
  Lines         708      753      +45     
==========================================
+ Hits          618      628      +10     
- Misses         90      125      +35     
Impacted Files Coverage Δ
...ication/Onboarding/AccountSetup/AccountSetup.swift 94.80% <95.00%> (-0.76%) ⬇️
...plication/Onboarding/NotificationPermissions.swift 95.24% <95.24%> (ø)
...eApplication/Onboarding/HealthKitPermissions.swift 95.46% <100.00%> (+0.34%) ⬆️
...emplateApplication/Onboarding/OnboardingFlow.swift 92.60% <100.00%> (+0.93%) ⬆️
...cation/Schedule/TemplateApplicationScheduler.swift 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a31c92f...459e199. Read the comment docs.

@PSchmiedmayer PSchmiedmayer merged commit 8a05588 into main Jun 30, 2023
4 checks passed
@PSchmiedmayer PSchmiedmayer deleted the feature/notifications branch June 30, 2023 22:43
NikolaiMadlener pushed a commit to NikolaiMadlener/SpeziTemplateApplication that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant