Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Account Setup and new Account Editing Functionality #35

Merged
merged 16 commits into from
Sep 23, 2023

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Sep 2, 2023

Updated Account Setup and new Account Editing Functionality

♻️ Current situation & Problem

There is an upcoming release of SpeziAccount that restructures and simplifies account setup procedure. Further, it adds a new Account Overview that allows you to view and edit your active account details.

While it might not be required for all projects, we currently force a user account (e.g. as the standard expects a user account for all operations) even if the user decides to log out.

Furthermore, we restore test case functionality for some tests cases that broke due to the latest accessibility improvements in some dependencies.

For more information see:

⚙️ Release Notes

  • Newly designed Account Setup experience
  • New Account Editing Functionality
  • Support complete removal of user data

📚 Documentation

In code documentation was adjusted.

✅ Testing

Tests were updated to cover new vectors.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Supereg
Copy link
Member Author

Supereg commented Sep 2, 2023

This is currently blocked by StanfordSpezi/SpeziOnboarding#21

see StanfordSpezi/SpeziAccount#23

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #35 (0a6b981) into main (d310ca1) will increase coverage by 0.82%.
The diff coverage is 92.83%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   80.86%   81.68%   +0.82%     
==========================================
  Files          30       32       +2     
  Lines         815      846      +31     
==========================================
+ Hits          659      691      +32     
+ Misses        156      155       -1     
Files Changed Coverage Δ
...n/Onboarding/OnboardingFlow+PreviewSimulator.swift 0.00% <0.00%> (ø)
...tion/Schedule/TemplateApplicationTaskContext.swift 43.75% <66.67%> (ø)
TemplateApplication/Account/AccountSheet.swift 78.95% <78.95%> (ø)
...plateApplication/TemplateApplicationStandard.swift 37.65% <85.00%> (+3.92%) ⬆️
TemplateApplication/MockUpload/MockUpload.swift 92.31% <87.50%> (-7.69%) ⬇️
...emplateApplication/Schedule/EventContextView.swift 90.91% <87.50%> (-1.19%) ⬇️
TemplateApplication/Schedule/ScheduleView.swift 86.91% <88.89%> (+1.38%) ⬆️
...eApplication/Account/AccountRequiredModifier.swift 96.16% <96.16%> (ø)
TemplateApplication/Account/AccountButton.swift 100.00% <100.00%> (ø)
...mplateApplication/Account/AccountRequiredKey.swift 100.00% <100.00%> (ø)
... and 12 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d310ca1...0a6b981. Read the comment docs.

@Supereg
Copy link
Member Author

Supereg commented Sep 20, 2023

We still want to incorporate StanfordSpezi/SpeziAccount#24

EDIT: ✅

@Supereg Supereg changed the title Upgrade SpeziAccount Updated Account Setup and new Account Editing Functionality Sep 20, 2023
@Supereg Supereg marked this pull request as ready for review September 20, 2023 22:50
@Supereg Supereg added the enhancement New feature or request label Sep 20, 2023
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the improvements @Supereg, great to see the new account module in the Template Application! 🚀

I only had a comment to reuse the account button across the different tabs to display it in a consistent position. Apart from this I am happy to see the PR being merged 👍

TemplateApplication/Schedule/ScheduleView.swift Outdated Show resolved Hide resolved
@Supereg Supereg enabled auto-merge (squash) September 22, 2023 23:29
@Supereg Supereg merged commit 162260a into main Sep 23, 2023
9 checks passed
@Supereg Supereg deleted the feature/spezi-account-upgrade branch September 23, 2023 00:13
NikolaiMadlener pushed a commit to NikolaiMadlener/SpeziTemplateApplication that referenced this pull request Oct 18, 2023
…Spezi#35)

There is an upcoming release of SpeziAccount that restructures and
simplifies account setup procedure. Further, it adds a new Account
Overview that allows you to view and edit your active account details.

While it might not be required for all projects, we currently force a
user account (e.g. as the standard expects a user account for all
operations) even if the user decides to log out.

Furthermore, we restore test case functionality for some tests cases
that broke due to the latest accessibility improvements in some
dependencies.

For more information see:
* StanfordSpezi/SpeziAccount#7
* StanfordSpezi/SpeziFirebase#8

* Newly designed Account Setup experience
* New Account Editing Functionality
* Support complete removal of user data

In code documentation was adjusted.

Tests were updated to cover new vectors.

By submitting creating this pull request, you agree to follow our [Code
of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md):
- [x] I agree to follow the [Code of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).
NikolaiMadlener pushed a commit to NikolaiMadlener/SpeziTemplateApplication that referenced this pull request Oct 18, 2023
…Spezi#35)

# Updated Account Setup and new Account Editing Functionality

## ♻️ Current situation & Problem
There is an upcoming release of SpeziAccount that restructures and
simplifies account setup procedure. Further, it adds a new Account
Overview that allows you to view and edit your active account details.

While it might not be required for all projects, we currently force a
user account (e.g. as the standard expects a user account for all
operations) even if the user decides to log out.

Furthermore, we restore test case functionality for some tests cases
that broke due to the latest accessibility improvements in some
dependencies.

For more information see:
* StanfordSpezi/SpeziAccount#7
* StanfordSpezi/SpeziFirebase#8

## ⚙️ Release Notes 
* Newly designed Account Setup experience
* New Account Editing Functionality
* Support complete removal of user data

## 📚 Documentation
In code documentation was adjusted.

## ✅ Testing
Tests were updated to cover new vectors.


## 📝 Code of Conduct & Contributing Guidelines 

By submitting creating this pull request, you agree to follow our [Code
of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md):
- [x] I agree to follow the [Code of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).
NikolaiMadlener pushed a commit to NikolaiMadlener/SpeziTemplateApplication that referenced this pull request Oct 18, 2023
…Spezi#35)

# Updated Account Setup and new Account Editing Functionality

## ♻️ Current situation & Problem
There is an upcoming release of SpeziAccount that restructures and
simplifies account setup procedure. Further, it adds a new Account
Overview that allows you to view and edit your active account details.

While it might not be required for all projects, we currently force a
user account (e.g. as the standard expects a user account for all
operations) even if the user decides to log out.

Furthermore, we restore test case functionality for some tests cases
that broke due to the latest accessibility improvements in some
dependencies.

For more information see:
* StanfordSpezi/SpeziAccount#7
* StanfordSpezi/SpeziFirebase#8

## ⚙️ Release Notes 
* Newly designed Account Setup experience
* New Account Editing Functionality
* Support complete removal of user data

## 📚 Documentation
In code documentation was adjusted.

## ✅ Testing
Tests were updated to cover new vectors.


## 📝 Code of Conduct & Contributing Guidelines 

By submitting creating this pull request, you agree to follow our [Code
of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md):
- [x] I agree to follow the [Code of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).
NikolaiMadlener pushed a commit to NikolaiMadlener/SpeziTemplateApplication that referenced this pull request Oct 18, 2023
…Spezi#35)

# Updated Account Setup and new Account Editing Functionality

## ♻️ Current situation & Problem
There is an upcoming release of SpeziAccount that restructures and
simplifies account setup procedure. Further, it adds a new Account
Overview that allows you to view and edit your active account details.

While it might not be required for all projects, we currently force a
user account (e.g. as the standard expects a user account for all
operations) even if the user decides to log out.

Furthermore, we restore test case functionality for some tests cases
that broke due to the latest accessibility improvements in some
dependencies.

For more information see:
* StanfordSpezi/SpeziAccount#7
* StanfordSpezi/SpeziFirebase#8

## ⚙️ Release Notes 
* Newly designed Account Setup experience
* New Account Editing Functionality
* Support complete removal of user data

## 📚 Documentation
In code documentation was adjusted.

## ✅ Testing
Tests were updated to cover new vectors.


## 📝 Code of Conduct & Contributing Guidelines 

By submitting creating this pull request, you agree to follow our [Code
of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md):
- [x] I agree to follow the [Code of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).
NikolaiMadlener pushed a commit to NikolaiMadlener/SpeziTemplateApplication that referenced this pull request Oct 18, 2023
…Spezi#35)

There is an upcoming release of SpeziAccount that restructures and
simplifies account setup procedure. Further, it adds a new Account
Overview that allows you to view and edit your active account details.

While it might not be required for all projects, we currently force a
user account (e.g. as the standard expects a user account for all
operations) even if the user decides to log out.

Furthermore, we restore test case functionality for some tests cases
that broke due to the latest accessibility improvements in some
dependencies.

For more information see:
* StanfordSpezi/SpeziAccount#7
* StanfordSpezi/SpeziFirebase#8

* Newly designed Account Setup experience
* New Account Editing Functionality
* Support complete removal of user data

In code documentation was adjusted.

Tests were updated to cover new vectors.

By submitting creating this pull request, you agree to follow our [Code
of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md):
- [x] I agree to follow the [Code of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).
NikolaiMadlener pushed a commit to NikolaiMadlener/SpeziTemplateApplication that referenced this pull request Oct 18, 2023
…Spezi#35)

There is an upcoming release of SpeziAccount that restructures and
simplifies account setup procedure. Further, it adds a new Account
Overview that allows you to view and edit your active account details.

While it might not be required for all projects, we currently force a
user account (e.g. as the standard expects a user account for all
operations) even if the user decides to log out.

Furthermore, we restore test case functionality for some tests cases
that broke due to the latest accessibility improvements in some
dependencies.

For more information see:
* StanfordSpezi/SpeziAccount#7
* StanfordSpezi/SpeziFirebase#8

* Newly designed Account Setup experience
* New Account Editing Functionality
* Support complete removal of user data

In code documentation was adjusted.

Tests were updated to cover new vectors.

By submitting creating this pull request, you agree to follow our [Code
of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md):
- [x] I agree to follow the [Code of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants