Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues writing to Firestore #46

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Fix issues writing to Firestore #46

merged 1 commit into from
Oct 24, 2023

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Oct 23, 2023

Fix firestore rules

♻️ Current situation & Problem

The firestore rules were ill-formatted and therefore all write to the firestore simulator were rejected. This PR fixes this problem by updating the firestore.rules configuration to include the version information and fixing syntax issues.

⚙️ Release Notes

  • Fixed issues writing to Firestore

📚 Documentation

--

✅ Testing

--

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #46 (08726e3) into main (5796d90) will decrease coverage by 0.20%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
- Coverage   81.80%   81.60%   -0.20%     
==========================================
  Files          35       35              
  Lines         978      978              
==========================================
- Hits          800      798       -2     
- Misses        178      180       +2     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5796d90...08726e3. Read the comment docs.

@Supereg Supereg enabled auto-merge (squash) October 24, 2023 00:06
@Supereg Supereg merged commit 092d431 into main Oct 24, 2023
6 checks passed
@Supereg Supereg deleted the fix/firestore-rules branch October 24, 2023 00:31
@PSchmiedmayer
Copy link
Member

Thank you @Supereg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants