Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade app to latest Spezi releases #56

Merged
merged 6 commits into from
Nov 16, 2023
Merged

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Nov 11, 2023

Upgrade app to latest Spezi releases

♻️ Current situation & Problem

This PR migrates the template app to use the new Observable framework. Further it updates the template app to the latest releases of the Spezi framework ecosystem.

⚙️ Release Notes

  • Update to the latest Spezi releases
  • Migrate to Observable

📚 Documentation

--

✅ Testing

  • UI tests were updated and adjusted.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Supereg Supereg marked this pull request as ready for review November 14, 2023 06:57
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #56 (a78b8a6) into main (a7a84e4) will decrease coverage by 2.08%.
The diff coverage is 47.06%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   82.58%   80.50%   -2.08%     
==========================================
  Files          35       33       -2     
  Lines         987      938      -49     
==========================================
- Hits          815      755      -60     
- Misses        172      183      +11     
Files Coverage Δ
...mplateApplication/Account/AccountSetupHeader.swift 100.00% <ø> (ø)
TemplateApplication/Account/AccountSheet.swift 95.66% <ø> (-2.17%) ⬇️
TemplateApplication/Home.swift 100.00% <100.00%> (ø)
TemplateApplication/MockUpload/MockUpload.swift 92.31% <ø> (ø)
...lateApplication/Onboarding/AccountOnboarding.swift 88.89% <ø> (ø)
TemplateApplication/Onboarding/Consent.swift 94.12% <ø> (ø)
...eApplication/Onboarding/HealthKitPermissions.swift 95.56% <ø> (ø)
...ateApplication/Onboarding/InterestingModules.swift 100.00% <ø> (ø)
...plication/Onboarding/NotificationPermissions.swift 95.56% <ø> (ø)
...emplateApplication/Onboarding/OnboardingFlow.swift 97.23% <ø> (ø)
... and 5 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a84e4...a78b8a6. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the updates and improvements, those look great @Supereg! 🚀

TemplateApplication.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
TemplateApplication.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
@Supereg Supereg enabled auto-merge (squash) November 16, 2023 00:16
@PSchmiedmayer PSchmiedmayer merged commit 4623d82 into main Nov 16, 2023
7 of 8 checks passed
@PSchmiedmayer PSchmiedmayer deleted the feature/spezi-upgrade branch November 16, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants