Don't commit build artifacts (dist and lib) to source control

[Daniel15]

Build artifacts (such as the dist and lib directories in this repo) don't belong in source control 😃

[Stanko]

Generally speaking you are right, but as this repo is used as a npm package, it should include production ready assets. That's why I did it this way.

It is kinda hard to have a nice workflow for releasing react components to npm, so if you have any ideas, I'm open for suggestions. Thanks!

[Daniel15]

Sorry it took me a while to reply. For the npm package, you simply need to make sure that the build runs before publishing. You could add it as a prepublish step if you like. Take a look at how I handle Babel-standalone as an example, or how React works. Neither of them have the build artifacts in source control, but they do have a dist directory in the resulting npm package. You simply need to add the dist directory to gitignore but *not* npmignore. Sent from my phone.

…

On Apr 28, 2017 7:23 AM, "Stanko" ***@***.***> wrote: Closed #6 <#6>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFnHZsamtiNUNotFT1CdvrE281A8y2Cks5r0fZKgaJpZM4NFOtp> .

[Stanko]

Thanks, that makes sense, I'll take a look how they do it. Btw if you can direct me to a boilerplate for developing and releasing react components to npm, I would greatly appreciate it!

[Daniel15]

Boilerplates always seem pretty overengineered to me, so I don't have experience with them as I've never used any of them.

[kentandersen]

👍 on removing dist and lib from source code

No need for boilerplate. Just do what @Daniel15 described

1. add dist and lib to .gitignore, but not .npmignore
2. add "prepublish": "npm run build" to scripts in package.json

When you run npm publish dist and lib will be updated before its pushed to npm. .gitignore will keep them out of source control

[Stanko]

Thank you very much both of you guys. I just fixed this (23aa395) and published. .npmignore was the thing I was missing.

@kentandersen thanks for the other PR as well.