Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support pooling of YieldInstruction for CoroutineUtility.cs #92

Closed
pavlo-klymentenko-legacy opened this issue May 6, 2022 · 1 comment
Closed

feat: Support pooling of YieldInstruction for CoroutineUtility.cs #92

pavlo-klymentenko-legacy opened this issue May 6, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@pavlo-klymentenko-legacy
Copy link
Contributor

pavlo-klymentenko-legacy commented May 6, 2022 •
edited
Loading

An idea is to pool YieldInstruction intead of creating new ones to prevent useless memory allocations.
Also important question is which ones? Probably should be generic by type.
@pavlo-klymentenko-legacy pavlo-klymentenko-legacy added the enhancement New feature or request label May 6, 2022
AlexWargon added a commit that referenced this issue May 9, 2022
@AlexWargon
feat: Support pooling of YieldInstruction for Coroutines #92
a85f44c
kodiakhq bot pushed a commit that referenced this issue May 25, 2022
@AlexWargon
feat: Support pooling of YieldInstruction for Coroutines #92 (#94)
4720e55 
* feat: Support pooling of YieldInstruction for Coroutines #92

* fix. add namespace

* fix: fix pool request

* fix: pool request fixes

* fix: reformat code with rider
@alexey-yaremenko
Copy link
Contributor

This is implemented and merged into master in #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexey-yaremenko @pavlo-klymentenko-legacy