Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create rect extesion #103

Merged
merged 8 commits into from
Feb 20, 2023
Merged

chore: create rect extesion #103

merged 8 commits into from
Feb 20, 2023

Conversation

nikita-mordik
Copy link
Contributor

@nikita-mordik nikita-mordik commented Feb 15, 2023

Purpose of this PR

Create RectExtensions class

Testing status

  • Includes unit tests.

Manual testing status

Tested in the editor using sample scene.

@nikita-mordik nikita-mordik linked an issue Feb 15, 2023 that may be closed by this pull request
9 tasks
@nikita-mordik nikita-mordik self-assigned this Feb 15, 2023
@nikita-mordik nikita-mordik added the enhancement New feature or request label Feb 15, 2023
@github-actions github-actions bot removed the enhancement New feature or request label Feb 15, 2023
Copy link
Contributor

@alexey-yaremenko alexey-yaremenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have to move this RectExtensions class to the Editor/Extensions folder. Because these extensions are mainly for speeding up GUI layout development.

Also, please, double-check some of the RectExtensions methods (e.g. Above and Below) - they are definitely incorrect.

@nikita-mordik nikita-mordik added the enhancement New feature or request label Feb 16, 2023
@github-actions github-actions bot removed the enhancement New feature or request label Feb 17, 2023
Copy link
Contributor

@alexey-yaremenko alexey-yaremenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great update! Thank you!

@kodiakhq kodiakhq bot merged commit faf17f2 into master Feb 20, 2023
@kodiakhq kodiakhq bot deleted the chore/rect-extension branch February 20, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move RectExtensions utility to Foundation package & extend it's API
2 participants