feat: fancy component pool implementation #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stan-osipov
approved these changes
Jul 14, 2021
There was a problem hiding this comment.
Pretty cool.
Can you please also add a usage example here:
https://github.com/StansAssets/com.stansassets.foundation/wiki/Pooling-Pattern#prefabs-spawn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
A fancy version of Component Pool implementation was added to the package.
Intent:
There is a PrefabPool implementation available in the Foundation package already.
Besides the cases where you need only a pure GameObject entity instantiated from the prefab source, there are cases where you want to have a component instance from the prefab root. So this pool implementation is exactly about it.
Testing status
Manual testing status
Tested in Unity Editor.