Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

my improvements for sm64dse #3

Closed
wants to merge 3 commits into from
Closed

Conversation

jupahe64
Copy link

@jupahe64 jupahe64 commented Nov 7, 2017

This is something i have worked on for a while. It's sm64dse 2.3.5 with some

Changes:
-a better ObjectRenderer for:
Paintings(they are rotated properly),
Exits(they show their exact rotation, width and height)
InvisiblePole(showing the actual height),
StarMarkers(you now can see if it is for red coins or something else)
-the highlight of a path now also shows the connections between the nodes,
Bugfixes:
-scrolling an object works again
-if you set an object to be on another layer, all involved layers will update, so it doesn't crash if
you reselect the object thats already unloaded from the objectlist
New Features:
-copy and paste coordinates buttons
-a new alternate interface for editing the LevelObjects Properties,
-in the 3d model tab it's possible now to select the different areas of the level to show up
-the view will zoom to an object if you doubleClick it in the object list

I would like, if this could be an official update for sm64dse.

btw. all these files are copied from my own project: https://github.com/jupahe64/my-improved-version-of-sm64dse
i just now realised that it would be better to do it as a pull request

@Fiachra1993
Copy link
Collaborator

Thanks for the pull request however I can't review it in its current state due to the line endings of over 200 files having been changed. Could you try the following:

In the meantime I can test your changes out.

@Fiachra1993
Copy link
Collaborator

These are good features especially the exit rendering and the parameter settings for exits, views etc. Well done for working out what "Type 14" objects are for.

A few suggestions/issues:

  • Selecting an exit object and then selecting the table property view causes the editor to crash
  • Ensure proper text on any labels, descriptions etc. e.g. "CopyCoordinates" -> "Copy Co-ordinates"
  • Ensure no overlapping UI controls e.g. the view object parameters 2 and 3 are cut off a bit at the top and the box for parameter 3 overlaps the lower control border
  • For the raw parameters in the "New" interface, pad the values with zeros so "000F" instead of "F" for example

If you need help fixing the line endings issue let me know and I can try it myself.

@jupahe64
Copy link
Author

jupahe64 commented Dec 8, 2017

Alright, i think i fixed almost all issues you told me, i made a completely new control/widget to make raw editing a lot easier, also polished the design of the "New interface" and btw. got rid of the "Old" one, as in my opinion its no longer needed. Also i extended the star marker/ power star-Render to show all known types with accurate models. And i implemented an easy way to set up paintings, stars and star markers in the new interface. Btw. i figured out that the painting actually contains 5 parameters, one of them being the type/mode/wobble/appearance. Also found a better way to organize path and fixed the bug that saved them in the wrong order. And there is now an auto file filtering for BMDs, BCAs, KLCs, BTPs and all 2d formats, which will avoid that someone accidentally selects the wrong file type.
These are the mayor changes i made in the meantime, i hope you like them.

@jupahe64
Copy link
Author

jupahe64 commented Dec 8, 2017

And is there a better way to communicate? Cause i may have some questions during development.

@awiebe
Copy link

awiebe commented Dec 15, 2017

NB There are also a bunch of .DS_Store you should add to your global gitignore.

@Fiachra1993
Copy link
Collaborator

Thanks, I'll take a look over the weekend.

@Fiachra1993
Copy link
Collaborator

Fiachra1993 commented Dec 18, 2017

Can you please merge the latest changes from my master branch into your (or just add a .gitattributes file to your repository with the following content: https://github.com/StapleButter/SM64DSe/blob/master/.gitattributes)

I have some minor changes I'd like to make. If you add that .gitattributes to your repository:

  • I'll open a pull request for my changes into yours
  • You (review and) merge my PR
  • You then open a PR from your repo. into mine which would include the changes I've made and won't include changes to line endings.

Good work.

If you have questions you can e-mail me: Fiachra93@yandex.com

@jupahe64
Copy link
Author

Alright i added the gitattributes

@Fiachra1993
Copy link
Collaborator

As discussed: jupahe64#1

@Fiachra1993
Copy link
Collaborator

Merged in latest commit: don't know best way to make changes on top of a github PR like this. Have updated list of contributers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants