Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helpers overhaul #268

Merged
merged 27 commits into from
Sep 22, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
393258c
Splitting up helpers, and laying the groundwork for expansion.
Sep 4, 2022
290f9d6
Overhaul of helpers.
Sep 13, 2022
91a651f
Run cargo fmt.
Sep 13, 2022
7dec299
Clippy suggestions.
Sep 13, 2022
56f5820
Fixing isometric projections, and enabling use of the new helper code…
Sep 13, 2022
3b5b884
Bring hexagon shaders up to speed.
Sep 14, 2022
6f2d00a
Beginning to work on the example to along with the helpers-overhaul.
Sep 15, 2022
e4558f9
Added an example which highlights tile labels on mouse hover; it reve…
Sep 16, 2022
1e676d3
Fixed hexagon related errors.
Sep 17, 2022
6807db6
Trying to fix the isometric grid issue.
Sep 18, 2022
c384e86
Fixed isometric issues; simplified hex shaders slightly.
Sep 18, 2022
44493d5
Remove projection_testing.rs
Sep 18, 2022
efbf252
Remove unnecessary comment in mouse_to_tile.rs example.
Sep 18, 2022
21f5723
Fix example window title, and address clippy suggestions.
Sep 18, 2022
f7d37b6
Documentation + fixes of various sorts.
Sep 19, 2022
7bbc08f
Variable renaming + cargo fmt + clippy + more docs.
Sep 19, 2022
23bdce3
Add instructions to mouse_to_tile.rs
Sep 19, 2022
606aed6
Make neighbor helper functions public.
Sep 19, 2022
7d8c471
Merge branch 'main' into helpers-overhaul
bzm3r Sep 19, 2022
873b8de
Make sure examples are running.
Sep 19, 2022
36c166f
Fixing mouse picking for hex row grid.
Sep 19, 2022
c86a6ab
Addressing review comments, adding more comments to example, and tryi…
Sep 20, 2022
9039024
Troubleshooting missing tile labels.
Sep 20, 2022
415f282
More trouble-shooting, more commenting.
Sep 20, 2022
668929b
Implemented workaround for annoying z-layering issue.
Sep 21, 2022
b0e0b1c
Merge branch 'main' into helpers-overhaul
bzm3r Sep 21, 2022
8d7ea79
Cargo fmt
Sep 21, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,12 @@ tiled = { version = "0.9", default-features = false }
[dev-dependencies.bevy]
version = "0.8"
default-features = false
features=["bevy_core_pipeline", "bevy_render", "bevy_asset", "png", "bevy_winit", "filesystem_watcher"]
features=["bevy_core_pipeline", "bevy_render", "bevy_asset", "png", "bevy_winit", "bevy_text", "bevy_sprite", "filesystem_watcher"]

[target.'cfg(unix)'.dev-dependencies.bevy]
version = "0.8"
default-features = false
features=["bevy_core_pipeline", "bevy_render", "bevy_asset", "png", "bevy_winit", "x11"]
features=["bevy_core_pipeline", "bevy_render", "bevy_asset", "png", "bevy_winit", "x11", "bevy_text", "bevy_sprite"]

[target.wasm32-unknown-unknown]
runner = "wasm-server-runner"
Expand Down
Binary file added assets/bw-tile-hex-col.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/bw-tile-hex-row.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/bw-tile-iso.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/bw-tile-square.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/fonts/FiraSans-Bold.ttf
Binary file not shown.
4 changes: 2 additions & 2 deletions examples/accessing_tiles.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ fn startup(mut commands: Commands, asset_server: Res<AssetServer>) {
// For the purposes of this example, we consider a square tile map,
// where diagonals are also considered to be neighbors.
let tilemap_type = TilemapType::Square {
neighbors_include_diagonals: true,
diagonal_neighbors: true,
};

// Create a tilemap entity a little early
Expand Down Expand Up @@ -89,7 +89,7 @@ fn startup(mut commands: Commands, asset_server: Res<AssetServer>) {
map_type: tilemap_type,
texture: TilemapTexture(texture_handle),
tile_size,
transform: get_centered_transform_2d(&tilemap_size, &tile_size, 0.0),
transform: get_tilemap_center_transform(&tilemap_size, &tile_size, 0.0),
..Default::default()
})
.insert(LastUpdate(0.0))
Expand Down
4 changes: 2 additions & 2 deletions examples/animation.rs
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ fn create_background(mut commands: Commands, asset_server: Res<AssetServer>) {
tile_size,
storage: tilemap_storage,
texture: TilemapTexture(texture_handle.clone()),
transform: get_centered_transform_2d(&size, &tile_size, 0.0),
transform: get_tilemap_center_transform(&size, &tile_size, 0.0),
..Default::default()
});
}
Expand Down Expand Up @@ -123,7 +123,7 @@ fn create_animated_flowers(mut commands: Commands, asset_server: Res<AssetServer
storage: tilemap_storage,
texture: TilemapTexture(texture_handle.clone()),
tile_size,
transform: get_centered_transform_2d(&size, &tile_size, 1.0),
transform: get_tilemap_center_transform(&size, &tile_size, 1.0),
..Default::default()
});
}
Expand Down
5 changes: 3 additions & 2 deletions examples/basic.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
use bevy::{prelude::*, render::texture::ImageSettings};
use bevy_ecs_tilemap::prelude::*;

mod helpers;

fn startup(
Expand Down Expand Up @@ -54,7 +55,7 @@ fn startup(
storage: tile_storage,
texture: TilemapTexture(texture_handle),
tile_size,
transform: get_centered_transform_2d(&tilemap_size, &tile_size, 0.0),
transform: get_tilemap_center_transform(&tilemap_size, &tile_size, 0.0),
..Default::default()
});

Expand All @@ -79,7 +80,7 @@ fn swap_texture_or_hide(
let texture_handle_a: Handle<Image> = asset_server.load("tiles.png");
let texture_handle_b: Handle<Image> = asset_server.load("tiles2.png");
for (mut tilemap_tex, _) in &mut query {
if &tilemap_tex.0 == &texture_handle_a {
if tilemap_tex.0 == texture_handle_a {
tilemap_tex.0 = texture_handle_b.clone();
} else {
tilemap_tex.0 = texture_handle_a.clone();
Expand Down
2 changes: 1 addition & 1 deletion examples/bench.rs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ fn startup(mut commands: Commands, asset_server: Res<AssetServer>) {
storage: tile_storage,
texture: TilemapTexture(texture_handle),
tile_size,
transform: get_centered_transform_2d(&tilemap_size, &tile_size, 0.0),
transform: get_tilemap_center_transform(&tilemap_size, &tile_size, 0.0),
..Default::default()
});
}
Expand Down
2 changes: 1 addition & 1 deletion examples/colors.rs
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ fn startup(mut commands: Commands, asset_server: Res<AssetServer>) {
texture: TilemapTexture(texture_handle),
tile_size,
map_type: TilemapType::Square {
neighbors_include_diagonals: false,
diagonal_neighbors: false,
},
..Default::default()
});
Expand Down
4 changes: 2 additions & 2 deletions examples/game_of_life.rs
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ fn startup(mut commands: Commands, asset_server: Res<AssetServer>) {
storage: tile_storage,
texture: TilemapTexture(texture_handle),
tile_size,
transform: get_centered_transform_2d(&tilemap_size, &tile_size, 0.0),
transform: get_tilemap_center_transform(&tilemap_size, &tile_size, 0.0),
map_type: TilemapType::Square {
neighbors_include_diagonals: true,
diagonal_neighbors: true,
},
..Default::default()
})
Expand Down
14 changes: 6 additions & 8 deletions examples/helpers/tiled.rs
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,8 @@ pub fn process_loaded_maps(
// TODO: Create a RemoveMap component..
for layer_entity in layer_storage.storage.values() {
if let Ok((_, layer_tile_storage)) = tile_storage_query.get(*layer_entity) {
for tile in layer_tile_storage.iter() {
if let Some(tile) = tile {
commands.entity(*tile).despawn_recursive()
}
for tile in layer_tile_storage.iter().flatten() {
commands.entity(*tile).despawn_recursive()
}
}
// commands.entity(*layer_entity).despawn_recursive();
Expand Down Expand Up @@ -170,15 +168,15 @@ pub fn process_loaded_maps(
TilemapType::Hexagon(HexCoordSystem::Row)
}
tiled::Orientation::Isometric => TilemapType::Isometric {
neighbors_include_diagonals: false,
diagonal_neighbors: false,
coord_system: IsoCoordSystem::Diamond,
},
tiled::Orientation::Staggered => TilemapType::Isometric {
neighbors_include_diagonals: false,
diagonal_neighbors: false,
coord_system: IsoCoordSystem::Staggered,
},
tiled::Orientation::Orthogonal => TilemapType::Square {
neighbors_include_diagonals: false,
diagonal_neighbors: false,
},
};

Expand Down Expand Up @@ -241,7 +239,7 @@ pub fn process_loaded_maps(
),
tile_size,
spacing: tile_spacing,
transform: bevy_ecs_tilemap::helpers::get_centered_transform_2d(
transform: get_tilemap_center_transform(
&map_size,
&tile_size,
layer.layer_index as f32,
Expand Down
4 changes: 2 additions & 2 deletions examples/layers.rs
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ fn startup(mut commands: Commands, asset_server: Res<AssetServer>) {
storage: tile_storage,
texture: TilemapTexture(texture_handle.clone()),
tile_size,
transform: get_centered_transform_2d(&tilemap_size, &tile_size, 0.0),
transform: get_tilemap_center_transform(&tilemap_size, &tile_size, 0.0),
..Default::default()
});

Expand All @@ -55,7 +55,7 @@ fn startup(mut commands: Commands, asset_server: Res<AssetServer>) {
storage: tile_storage,
texture: TilemapTexture(texture_handle),
tile_size: TilemapTileSize { x: 16.0, y: 16.0 },
transform: get_centered_transform_2d(&tilemap_size, &tile_size, 1.0)
transform: get_tilemap_center_transform(&tilemap_size, &tile_size, 1.0)
* Transform::from_xyz(32.0, 32.0, 0.0),
..Default::default()
});
Expand Down
3 changes: 2 additions & 1 deletion examples/ldtk/ldtk.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
use bevy_ecs_tilemap::{
helpers::geometry::get_tilemap_center_transform,
map::{TilemapGridSize, TilemapId, TilemapSize, TilemapTexture, TilemapTileSize},
tiles::{TileBundle, TilePos, TileStorage, TileTexture},
TilemapBundle,
Expand Down Expand Up @@ -208,7 +209,7 @@ pub fn process_loaded_tile_maps(
storage,
texture: TilemapTexture(texture),
tile_size,
transform: bevy_ecs_tilemap::helpers::get_centered_transform_2d(
transform: get_tilemap_center_transform(
&size,
&tile_size,
layer_id as f32,
Expand Down
Loading