Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC 1] Widget Restructuring #56

Merged
merged 8 commits into from
Jan 22, 2022

Conversation

MrGVSV
Copy link
Collaborator

@MrGVSV MrGVSV commented Jan 10, 2022

This RFC proposes a possible restructuring of widgets to allow for better separation of logic and a (hopefully) improved API.

@MrGVSV MrGVSV changed the title Added Widget Restructuring RFC Widget Restructuring RFC Jan 10, 2022
Copy link
Owner

@StarArawn StarArawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some initial thoughts. I need to read through it some more and think careful about some things.

rfcs/widget-restructure-rfc-1.md Outdated Show resolved Hide resolved
rfcs/widget-restructure-rfc-1.md Outdated Show resolved Hide resolved
rfcs/widget-restructure-rfc-1.md Show resolved Hide resolved
rfcs/widget-restructure-rfc-1.md Outdated Show resolved Hide resolved
rfcs/widget-restructure-rfc-1.md Outdated Show resolved Hide resolved
rfcs/widget-restructure-rfc-1.md Outdated Show resolved Hide resolved
@StarArawn StarArawn changed the title Widget Restructuring RFC [RFC 1] Widget Restructuring Jan 10, 2022
rfcs/widget-restructure-rfc-1.md Show resolved Hide resolved
rfcs/widget-restructure-rfc-1.md Outdated Show resolved Hide resolved
rfcs/widget-restructure-rfc-1.md Outdated Show resolved Hide resolved
rfcs/widget-restructure-rfc-1.md Outdated Show resolved Hide resolved
rfcs/widget-restructure-rfc-1.md Outdated Show resolved Hide resolved
rfcs/widget-restructure-rfc-1.md Outdated Show resolved Hide resolved
rfcs/widget-restructure-rfc-1.md Outdated Show resolved Hide resolved
@MrGVSV MrGVSV requested a review from StarArawn January 12, 2022 08:49
rfcs/widget-restructure-rfc-1.md Outdated Show resolved Hide resolved
rfcs/widget-restructure-rfc-1.md Outdated Show resolved Hide resolved
rfcs/widget-restructure-rfc-1.md Outdated Show resolved Hide resolved
rfcs/widget-restructure-rfc-1.md Outdated Show resolved Hide resolved
rfcs/widget-restructure-rfc-1.md Outdated Show resolved Hide resolved
@MrGVSV MrGVSV requested a review from StarArawn January 13, 2022 06:30
Copy link
Owner

@StarArawn StarArawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few very small notes. :) Overall this is looking great! 👍

rfcs/widget-restructure-rfc-1.md Outdated Show resolved Hide resolved
rfcs/widget-restructure-rfc-1.md Outdated Show resolved Hide resolved
rfcs/widget-restructure-rfc-1.md Show resolved Hide resolved
rfcs/widget-restructure-rfc-1.md Show resolved Hide resolved
@MrGVSV MrGVSV requested a review from StarArawn January 17, 2022 23:49
@StarArawn StarArawn merged commit b489c6b into StarArawn:main Jan 22, 2022
@MrGVSV MrGVSV deleted the widget-restructure-rfc-1 branch January 22, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants